Open
Conversation
Ajoute type int|string|null pour $key (était untyped, causait ParseError PHPStan).
Issue #102: toutes exceptions doivent implémenter LoggableInterface. Solution choisie (Option A - Interface Segregation): - Créer LoggableThrowableTrait combinant ThrowableTrait + toLog() - Exceptions opt-in LoggableInterface (pas héritage forcé) - Flexibilité pour exceptions non-loggables si besoin Changements: - Nouveau trait LoggableThrowableTrait avec méthode toLog() - 6 exceptions Common/Exception implémentent LoggableInterface - ThrowableInterface reste indépendant (pas extends LoggableInterface) Avantages: - Respecte principe Interface Segregation (SOLID) - Composition plutôt que couplage fort - Limite 5 méthodes ThrowableInterface préservée
Owner
Author
🔍 Automated Code Review✅ Positive pointsArchitecture:
Elegant Objects:
Code quality:
📝 Suggestions (non-blocking)Tests:
Documentation:
✅ ValidationCode ready to merge. PHP syntax validated. Solid architecture respecting project conventions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements LoggableInterface for all framework exceptions via an optional trait, following issue #102.
Changes
Architecture (Option A - Interface Segregation):
LoggableThrowableTraitcombiningThrowableTrait+toLog()methodCommon/Exceptionclasses now implementLoggableInterfaceThrowableInterfaceremains independent (no forced extension ofLoggableInterface)Modified files:
src/Common/Exception/LoggableThrowableTrait.phpimplements LoggableInterface, use LoggableThrowableTraitUnshiftInterface.phpexplicit$keyparameter typingAdvantages:
ThrowableInterface5-method limit preservedTesting
Checklist
Fixes #102