Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1052 +/- ##
==========================================
+ Coverage 82.65% 82.70% +0.04%
==========================================
Files 89 89
Lines 7022 7041 +19
==========================================
+ Hits 5804 5823 +19
Misses 1218 1218
☔ View full report in Codecov by Sentry. |
rrsadykov
left a comment
There was a problem hiding this comment.
I am not sure that LDS as it is implemented is a proper explore strategy. For me, explore strategy is for more about in which order we explore generated children, and not about filtering the generated children. The original LDS was proposed in http://cse.unl.edu/~choueiry/Documents/LDS.pdf as a complete search, but with different explore order of nodes.
Also, the LDS explore strategy as it is implemented now is not that much useful, as it just truncates the number of children generated, if we generate too much. I think we should already generate exactly the number of children we need in diving, as every generated child is not cheap (we do preprocessing for each generated child).
|
I agree, I'll move the code so we can qualify it as a tree search algorithm. It won't the implemantation of the lds though. We'll have to figure out how we can transmit the number of exepected children to the divide algorithm. |
|
My understanding is that there should be a storage unit which keeps the tabu list of variables forbidden to the added to the partial solution. The dive algorithm generates the children as long as the size of the tabu list is not more than the maximum size (which is a parameter of the dive algorithm). There is another parameter which is the maximum depth, if the current depth is larger than the maximum one, one only child should be generated. |
No description provided.