Define AnnotationCallback to replace Nothing#106
Merged
rrsadykov merged 1 commit intoatoptima:masterfrom Jul 16, 2025
Merged
Conversation
rrsadykov
approved these changes
Jul 16, 2025
Collaborator
|
Dear @blegat, Thank you for your contribution! |
blegat
force-pushed
the
annotation_callback
branch
from
c7964d2 to
33f355d
Compare
Contributor
Author
|
I have rebased it |
|
I'll add BlockDecomposition to our tests so we don't break things in the future: jump-dev/MathOptInterface.jl#2785 I also added Coluna |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
nothingno longer works because of jump-dev/MathOptInterface.jl#2575.Setting
nothingis considered as unsetting something so after jump-dev/MathOptInterface.jl#2575, it no longer considers thatMOI.set(sp.model, PricingCallback(), nothing)sets a pricing callback hencePricingCallbackis not in the list of model attributes set and we don't pass theifstatement inhttps://github.com/jump-dev/MathOptInterface.jl/blob/d66c13dab9cbd76c3451faffafd7d828a4e04ee1/src/Utilities/cachingoptimizer.jl#L358-L369
I noticed this error when trying to run the pricing example of Coluna.