Skip to content

Conversation

@n2p5
Copy link
Contributor

@n2p5 n2p5 commented Oct 29, 2025

Description

This is a DRAFT, WIP for integrating allinbits ICS1 https://github.com/allinbits/interchain-security into AtomOne.
This will stay in draft while we iron out e2e testing and consumer chain integration.

This PR integrates the ICS1 (Interchain Security v1) provider module from allinbits/interchain-security into AtomOne. ICS1 enables AtomOne validators to secure consumer chains using the provider chain's validator set, eliminating the need for consumer chains to bootstrap their own validator networks. This remains a work-in-progress draft. Outstanding work includes establishing end-to-end testing infrastructure with both provider and consumer chains to validate cross-chain security mechanics and validator compensation flows.

TODO: We'll be adding a more detailed breakdown of this work soon.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@n2p5 n2p5 mentioned this pull request Oct 29, 2025
20 tasks
Makefile Outdated
test-e2e: ARGS=-timeout=25m -v
test-e2e: TEST_PACKAGES=$(PACKAGES_E2E)
test-e2e: DOCKER_DEFAULT_PLATFORM=linux/amd64
test-e2e: docker-build-debug
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always want the latest docker build when running test-e2e, so this should be a build dep.

test-race: TEST_PACKAGES=$(PACKAGES_UNIT)
test-e2e: ARGS=-timeout=25m -v
test-e2e: TEST_PACKAGES=$(PACKAGES_E2E)
test-e2e: DOCKER_DEFAULT_PLATFORM=linux/amd64
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e is broken on arm, causing test-e2e to fail locally if on M-series Mac, but they pass on github, this ensures docker runs on linux/amd64

exclude-files:
- ".*\\.pb\\.go$"
- ".*\\.pb\\.gw\\.go$"

Copy link
Contributor Author

@n2p5 n2p5 Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to suppress a warning that using skip-dirs and skip-files is deprecated. and to move to exclude-dirs and exclude-files

@n2p5
Copy link
Contributor Author

n2p5 commented Nov 14, 2025

@tbruyelle @giunatale this is still a WIP, but I have a basic version of e2e tests working with a consumer chain binary we used from allinbits/interchain-security. We'll be adding more stuff to this soon.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 30, 2025
@github-actions github-actions bot closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant