-
Notifications
You must be signed in to change notification settings - Fork 33
feat: adding ICS1 ccv provider module #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Makefile
Outdated
| test-e2e: ARGS=-timeout=25m -v | ||
| test-e2e: TEST_PACKAGES=$(PACKAGES_E2E) | ||
| test-e2e: DOCKER_DEFAULT_PLATFORM=linux/amd64 | ||
| test-e2e: docker-build-debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We always want the latest docker build when running test-e2e, so this should be a build dep.
| test-race: TEST_PACKAGES=$(PACKAGES_UNIT) | ||
| test-e2e: ARGS=-timeout=25m -v | ||
| test-e2e: TEST_PACKAGES=$(PACKAGES_E2E) | ||
| test-e2e: DOCKER_DEFAULT_PLATFORM=linux/amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e is broken on arm, causing test-e2e to fail locally if on M-series Mac, but they pass on github, this ensures docker runs on linux/amd64
| exclude-files: | ||
| - ".*\\.pb\\.go$" | ||
| - ".*\\.pb\\.gw\\.go$" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to suppress a warning that using skip-dirs and skip-files is deprecated. and to move to exclude-dirs and exclude-files
|
@tbruyelle @giunatale this is still a WIP, but I have a basic version of e2e tests working with a consumer chain binary we used from |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
This is a DRAFT, WIP for integrating allinbits ICS1 https://github.com/allinbits/interchain-security into AtomOne.
This will stay in draft while we iron out e2e testing and consumer chain integration.
This PR integrates the ICS1 (Interchain Security v1) provider module from allinbits/interchain-security into AtomOne. ICS1 enables AtomOne validators to secure consumer chains using the provider chain's validator set, eliminating the need for consumer chains to bootstrap their own validator networks. This remains a work-in-progress draft. Outstanding work includes establishing end-to-end testing infrastructure with both provider and consumer chains to validate cross-chain security mechanics and validator compensation flows.
TODO: We'll be adding a more detailed breakdown of this work soon.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change