Fix no meetup file on AI folder #78
Conversation
✅ Deploy Preview for bitdevs-upgrade ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sbddesign
left a comment
sbddesign
left a comment
There was a problem hiding this comment.
Hey @lorenzolfm, I really appreciate you taking the initiative and attempting to fix this. I think this is a quality PR, but the root of the problem is really that the Readme file was not current.
My intended approach was that you can just run yarn summarize from the root directory. This script copies the necessary config files into the AI directory, and also invokes the necessary scripts from there. I have opened a PR here where I updated the Readme file to reflect how I intended it to be used. Could you try that out and see if it works for you?
The reason I like this is because I think it keeps the Dev Experience a little easier. If you want to use the template, you can fork it, and all your "unique" changes are confined to things like meetup.ts and the content dir. Furthermore, it keeps more of the config type stuff in plain open sight in the root dir.
Your approach is also valid. But were we to go that route, we would need to:
- alert people in the readme that there is now a 2nd config file they can update in the AI dir
- update the
upgrade.shscript to reflect that theaiprompt.tsfile should be ignored during upgrade
Does anyone have opinions on the better approach? To summarize:
- My approach is to maintain a single
meetup.tsconfig, and local summaries are invoked from the root directory usingyarn summarize. - Lorenzo's approach is to have
meetup.tsin the root and have a secondaiprompt.tsconfig nested in theai/srcdir, and summaries are invoked from inside of that directory.
| export interface Aiprompt { | ||
| summarized: AiType | ||
| eli5: AiType | ||
| } | ||
|
|
||
| type AiType = { | ||
| system: string | ||
| promptTemplate: string | ||
| } |
2 participants
Fix for #77