1117 improve document change detection to avoid unnecessary save prompts #29
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56fc9312eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Match asset:// URLs in new format: asset://uuid.ext or asset://uuid | ||
| const assetUrlRegex = /asset:\/\/([a-f0-9-]+)(?:\.[a-z0-9]+)?/gi; | ||
|
|
There was a problem hiding this comment.
The updated regex only matches the new asset://uuid.ext/asset://uuid format, so legacy URLs like asset://uuid/filename.jpg are matched only up to asset://uuid. The replacement then yields blob:.../filename.jpg, which is not a valid blob URL and will break image/audio rendering for existing projects that still store the legacy format (the rest of the codebase still documents/supports it). This is a regression in TinyMCE rendering for older content.
Useful? React with 👍 / 👎.
erseco
force-pushed
the
1117-improve-document-change-detection-to-avoid-unnecessary-save-prompts
branch
2 times, most recently
from
99fe83f to
20f9a92
Compare
erseco
force-pushed
the
1117-improve-document-change-detection-to-avoid-unnecessary-save-prompts
branch
from
d1728c9 to
8b9009a
Compare
don