Feature/improve e2e reliability #23
Conversation
…image optimization tool from the `exeimage` plugin.
…elative to their container to avoid breaking the layout.
…en an image has no alternative text.
…o 1023-tinymce-plugins-integrate-v302-fixes
…ithub.com/exelearning/exelearning into 1023-tinymce-plugins-integrate-v302-fixes
… show image in preview after insert'.
…exelearning#1070) * Fix licenses and allow empty ones (exe29) and backport the exe3 licenses * Fix tests * Allow legacy licenses * Allow un hideInFooter parameter
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5cc406c22
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| author: meta.author || '', | ||
| license: meta.license || 'creative commons: attribution - share alike 4.0', | ||
| license: meta.license || '', | ||
| description: meta.description || '', | ||
| licenseUrl: meta.licenseUrl || 'https://creativecommons.org/licenses/by-sa/4.0/', | ||
| licenseUrl: meta.licenseUrl || '', |
There was a problem hiding this comment.
Because exporters now pass licenseUrl: meta.licenseUrl || '', any project that only stores license (the common case; metadata does not populate licenseUrl) will render an empty href in the footer and omit the <link rel="license"> even for standard CC licenses. This is a regression from the prior default and leaves exports with non-functional license links. Consider computing a fallback via getLicenseUrl(license) (or the registry) when meta.licenseUrl is missing.
Useful? React with 👍 / 👎.
[Copilot is generating a summary...]