Skip to content

Conversation

@mishraa-G
Copy link

What this PR does

This PR adds missing test coverage for the --output=overwrite path in the optimize command.

While running the test suite, I noticed that the overwrite behavior wasn’t covered, even though this path updates the original AsyncAPI file. This test makes sure that behavior is exercised and helps protect against future regressions.

Why this is needed

Overwriting the original spec file is a sensitive operation, and having it untested could allow unintended changes to slip in unnoticed. Adding coverage here felt like a small but useful improvement.

What’s included

  • A unit test that verifies the original file is overwritten when --output=overwrite --no-tty is used
  • Assertions around the expected behavior without changing any existing logic

Related

Related to #1944

@changeset-bot
Copy link

changeset-bot bot commented Dec 31, 2025

⚠️ No Changeset found

Latest commit: 1d42a2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

1 participant