-
-
Notifications
You must be signed in to change notification settings - Fork 279
Fix/GitHub url parsing and extension check #1941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix/GitHub url parsing and extension check #1941
Conversation
🦋 Changeset detectedLatest commit: cff17df The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
We require all PRs to follow Conventional Commits specification. |
|



fix: github url parsing and file extension validation
Summary
This PR fixes two validation bugs that caused the CLI to fail for valid GitHub URLs and specification filenames.
raw.githubusercontent.com, correctly supporting branch names that contain slashes.split('.')withpath.extname(), correctly handling multi-dot filenames and no-extension edge cases.Changes
Verification
Result
The CLI now correctly processes all valid GitHub file URLs and specification files without false rejections or runtime failures.
#1940