fix: update dependencies #1932
fix: update dependencies #1932
Conversation
spc-28
requested review from
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
|
|
Hey @Shurtu-gal, |
|
Tests are failing right now. |
spc-28
force-pushed
the
deps/update-dependencies
branch
3 times, most recently
from
b6f0cd5 to
9da31e3
Compare
spc-28
force-pushed
the
deps/update-dependencies
branch
from
9da31e3 to
24db2f1
Compare
|
I have made the changes, and the tests are passing |
|
@Shurtu-gal please have a look and let me know if any changes are required |
package.json
Outdated
| "@asyncapi/diff": "^0.5.0", | ||
| "@asyncapi/generator": "^3.0.1", | ||
| "@asyncapi/modelina-cli": "^5.3.5", | ||
| "@asyncapi/generator-helpers": "^1.0.1", |
There was a problem hiding this comment.
Why generator-helpers has been added?
| "@oclif/core": "^4.2.9", | ||
| "@oclif/plugin-autocomplete": "^3.2.26", | ||
| "@clack/prompts": "^0.11.0", | ||
| "@oclif/core": "^4.8.0", |
There was a problem hiding this comment.
Does this have any breaking changes?
I know it shouldn't have as it is minor version upgrade but still 🤷🏻
| "config": "^4.0.0", | ||
| "body-parser": "^2.2.1", | ||
| "chalk": "^4.1.2", | ||
| "chokidar": "^4.0.3", |
There was a problem hiding this comment.
Same for this any breaking changes?
| "config": "^4.1.1", | ||
| "cors": "^2.8.5", | ||
| "express": "^4.17.1", | ||
| "express": "^5.2.1", |
There was a problem hiding this comment.
Could you run server-api once and test stuff out to see nothing is breaking?
package.json
Outdated
| "@commitlint/cli": "^20.2.0", | ||
| "@commitlint/config-conventional": "^20.2.0", |
There was a problem hiding this comment.
I don't think these are used anumore. Could you check once?
package.json
Outdated
| "@npmcli/package-json": "^7.0.4", | ||
| "@npmcli/fs": "^5.0.0", |
There was a problem hiding this comment.
Why these have been added?
| "nodemon": "^3.1.11", | ||
| "nyc": "^17.1.0", | ||
| "puppeteer": "^24.33.0", | ||
| "rimraf": "^6.1.2", |
There was a problem hiding this comment.
Any breaking changes we need to be aware of?
package.json
Outdated
| "simple-git": "^3.16.0", | ||
| "mocha": "^11.7.5", | ||
| "nodemon": "^3.1.11", | ||
| "nyc": "^17.1.0", |
There was a problem hiding this comment.
For this we can probably replace this with c8 and remove glob.
Reference: #1929 (comment)
There was a problem hiding this comment.
Could you remove the older eslint config?
spc-28
force-pushed
the
deps/update-dependencies
branch
from
cc88960 to
b00e270
Compare
|
@Shurtu-gal I’ve made the changes based on the provided comments. Please let me know if any further updates are required |
|
Also while working on this, I noticed that many newer dependency versions are ESM only, whereas our repository currently uses CommonJS. It may be helpful to keep ESM compatibility in mind for future updates to keep the codebase future proof |
There was a problem hiding this comment.
Why this change is needed?
|
@spc-28 I’ve analyzed the issue and the current PR. To keep the scope smaller and reduce unrelated changes, I think this can be addressed with fewer targeted updates instead of modifying multiple areas.
|
|
Hey @sarthakNITT, |
Any thoughts on this ? @Shurtu-gal |
|
FYI |
spc-28
force-pushed
the
deps/update-dependencies
branch
from
113fa96 to
22b0c5b
Compare
|
3 participants
Description
This PR updates key dependencies across the CLI to improve compatibility with the latest tooling
Key Changes:
Upgraded ESLint to v9 and migrated to the new flat config format
Updated core AsyncAPI packages, including a major upgrade to the generator
Upgraded testing libraries with necessary compatibility adjustments
Updated TypeScript and build-related tools to their latest stable versions
Related issue(s)
Issue: #1836