-
-
Notifications
You must be signed in to change notification settings - Fork 279
fix: regenerate package-lock.json with all platform-specific dependency #1895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: regenerate package-lock.json with all platform-specific dependency #1895
Conversation
🦋 Changeset detectedLatest commit: e192719 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset has been generated for this PR as part of auto-changeset workflow.Please review the changeset before merging the PR.If you are a maintainer or the author of the PR, you can change the changeset by clicking here Tip If you don't want auto-changeset to run on this PR, you can add the label |
|
Could someone please approve the workflow runs so we can test this fix on all platforms? This is a draft PR specifically to validate the package-lock.json fix on Linux/Windows CI runners. The issue (#1892) is that the lockfile was missing platform-specific dependencies, causing Once CI passes, I'll mark this as ready for review. |
princerajpoot20
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment. also, mark the PR as ready for review, once you are ready with your changes
9d847c8 to
4226452
Compare
|
@Kartikayy007 You still have not addressed the above suggestion |
3c18b81 to
4226452
Compare
|
|
@Kartikayy007 sorry buddy. that should be there. my bad |
no issues @princerajpoot20 that got me confused 😅, could you please run the CI to test if its not breaking. |
|
Good new people, now both CLI uses the next.js preinstalled with Studio. Also swc has been removed. Currently release is not working, once it is fixed we can close this PR as it might be not needed anymore. But for a sanity check @Kartikayy007 could you please regenerate package-lock now and see if any additions come in different machine. |



Description
This PR fixes the release pipeline failure by regenerating
package-lock.jsonwith all platform-specific optional dependencies.The Problem:
npm cierrors on Linux/Windows runners@swc/core-linux-x64-gnu,@next/swc-win32-x64-msvc, etc..exefiles and other platform-specific assetsThe Solution:
package-lock.jsonusingnpm installto include all platform-specific dependencies:Testing:
npm run build)Related issue(s)
Fixes #1892