Skip to content

Conversation

@Kartikayy007
Copy link
Contributor

Description

This PR fixes the release pipeline failure by regenerating package-lock.json with all platform-specific optional dependencies.

The Problem:

  • The release pipeline was failing with npm ci errors on Linux/Windows runners
  • The lockfile was missing platform-specific optional dependencies (only had macOS ARM64 entries)
  • CI couldn't install packages like @swc/core-linux-x64-gnu, @next/swc-win32-x64-msvc, etc.
  • This prevented generation of Windows .exe files and other platform-specific assets

The Solution:

  • Regenerated package-lock.json using npm install to include all platform-specific dependencies:
    • 10 @swc/core platform entries (darwin, linux, win32 variants)
    • 9 @next/swc platform entries (all Next.js platforms)
    • 24 @img/sharp platform entries (all Sharp image processing platforms)

Testing:

  • Local build passes (npm run build)
  • This is a draft PR to let CI validate the fix on Linux/Windows platforms
  • Once CI passes on all platforms, this PR will be marked as ready for review

Related issue(s)

Fixes #1892

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2025

🦋 Changeset detected

Latest commit: e192719

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

Changeset has been generated for this PR as part of auto-changeset workflow.

Please review the changeset before merging the PR.
---
'@asyncapi/cli': patch
---

fix: regenerate package-lock.json with all platform-specific dependency

- 4226452: fix: regenerate package-lock.json with all platform-specific dependencies
- f9f15ff: Delete .changeset/1895.md

If you are a maintainer or the author of the PR, you can change the changeset by clicking here

Tip

If you don't want auto-changeset to run on this PR, you can add the label skip-changeset to the PR or remove the changeset and change PR title to something other than fix: or feat:.

asyncapi-bot pushed a commit to Kartikayy007/cli that referenced this pull request Nov 12, 2025
asyncapi-bot pushed a commit to Kartikayy007/cli that referenced this pull request Nov 12, 2025
@Kartikayy007 Kartikayy007 marked this pull request as draft November 12, 2025 17:54
@Kartikayy007
Copy link
Contributor Author

Could someone please approve the workflow runs so we can test this fix on all platforms?
@princerajpoot20 @Shurtu-gal @AayushSaini101 @derberg

This is a draft PR specifically to validate the package-lock.json fix on Linux/Windows CI runners. The issue (#1892) is that the lockfile was missing platform-specific dependencies, causing npm ci to fail on Linux/Windows builds.

Once CI passes, I'll mark this as ready for review.

Copy link
Member

@princerajpoot20 princerajpoot20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment. also, mark the PR as ready for review, once you are ready with your changes

@github-project-automation github-project-automation bot moved this from To Triage to Backlog in CLI - Kanban Nov 15, 2025
@Kartikayy007 Kartikayy007 force-pushed the fix/package-lock-platform-dependencies branch from 9d847c8 to 4226452 Compare November 15, 2025 17:21
asyncapi-bot pushed a commit to Kartikayy007/cli that referenced this pull request Nov 15, 2025
@Kartikayy007 Kartikayy007 marked this pull request as ready for review November 15, 2025 17:22
asyncapi-bot pushed a commit to Kartikayy007/cli that referenced this pull request Nov 15, 2025
@princerajpoot20
Copy link
Member

@Kartikayy007 You still have not addressed the above suggestion

asyncapi-bot pushed a commit to Kartikayy007/cli that referenced this pull request Nov 16, 2025
asyncapi-bot pushed a commit to Kartikayy007/cli that referenced this pull request Nov 16, 2025
asyncapi-bot pushed a commit to Kartikayy007/cli that referenced this pull request Nov 16, 2025
@Kartikayy007 Kartikayy007 force-pushed the fix/package-lock-platform-dependencies branch from 3c18b81 to 4226452 Compare November 16, 2025 17:23
@sonarqubecloud
Copy link

@princerajpoot20
Copy link
Member

@Kartikayy007 sorry buddy. that should be there. my bad

@Kartikayy007
Copy link
Contributor Author

Kartikayy007 commented Nov 16, 2025

@Kartikayy007 sorry buddy. that should be there. my bad

no issues @princerajpoot20 that got me confused 😅, could you please run the CI to test if its not breaking.

@Shurtu-gal
Copy link
Collaborator

Good new people, now both CLI uses the next.js preinstalled with Studio. Also swc has been removed. Currently release is not working, once it is fixed we can close this PR as it might be not needed anymore.

But for a sanity check @Kartikayy007 could you please regenerate package-lock now and see if any additions come in different machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

[BUG] Fix release pipeline

3 participants