Skip to content

Conversation

@brajac709
Copy link

Hey I got kind of bored and started playing around with Rank Panda again. One thing I found was that I was able to get it to work with python 2.7. So I updated the README to reflect that. I think the other changes I've made were fairly minor (but those were done a while ago...). But I remember finding the python 2.6 download page was kind of difficult, plus its old and people should be using 2.7.

List comprehensions and useful dialogs for unlocking.
For ease of use, when adding waypoints, if a time is left blank it is
set to zero.
also started trying to make things iterative. still working on it....
Adds instructions for use with Python 2.7
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please line wrap to match the same column the initial """ starts on, and end with """ on its own line to match style elsewhere, such as here: https://github.com/astory/RankPanda/blob/master/RankPanda/RankLocation.py

(Please also do this for the rest of the docstrings)

thanks so much for moving these to docstrings though!

@ghost ghost assigned astory Jun 20, 2013
@astory
Copy link
Owner

astory commented Jun 20, 2013

This looks great. Most of my comments are stylistic. Let's follow https://google-styleguide.googlecode.com/svn/trunk/pyguide.html

Made iterative versions of  _GetLengthHelper and
_GetTValueAtLengthHelper.   Baseline tests show that they do the same
thing as recursive versions but more tests may be needed.
@brajac709
Copy link
Author

I think I covered mostly everything. Let me know if you find something I missed. I still want to keep the redundant functions in CubicHermiteSpline.py because my iterative versions have not been fully tested yet. I had made those changes a while ago without committing them so my git history was kind of messed up when I did some of this.

I'd say that the most recent commit is not 100% ready yet though: see the sed comment.... But I'll modify it once I get the original other files back. Just let me know if you find anything really bad that happened...

Made iterative versions of  _GetLengthHelper and
_GetTValueAtLengthHelper.   Baseline tests show that they do the same
thing as recursive versions but more tests may be needed.
 into brady_pythonify

Conflicts:
	RankPanda/RankLocation.py
@brajac709
Copy link
Author

ok.... so for some reason git didnt want to tell me about conflicts and was doing some weird things, so this commit history looks really messy. Also something strange happened to all the newlines, so the diffs look pretty bad too.... I think it works though. So let me know if there's any other style things or ways to reconcile this messiness....

Made iterative versions of  _GetLengthHelper and
_GetTValueAtLengthHelper.   Baseline tests show that they do the same
thing as recursive versions but more tests may be needed.
@astory astory removed their assignment Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants