-
Notifications
You must be signed in to change notification settings - Fork 3
Brady pythonify #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Brady pythonify #27
Conversation
For ease of use, when adding waypoints, if a time is left blank it is set to zero.
also started trying to make things iterative. still working on it....
Adds instructions for use with Python 2.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: please line wrap to match the same column the initial """ starts on, and end with """ on its own line to match style elsewhere, such as here: https://github.com/astory/RankPanda/blob/master/RankPanda/RankLocation.py
(Please also do this for the rest of the docstrings)
thanks so much for moving these to docstrings though!
|
This looks great. Most of my comments are stylistic. Let's follow https://google-styleguide.googlecode.com/svn/trunk/pyguide.html |
Made iterative versions of _GetLengthHelper and _GetTValueAtLengthHelper. Baseline tests show that they do the same thing as recursive versions but more tests may be needed.
|
I think I covered mostly everything. Let me know if you find something I missed. I still want to keep the redundant functions in CubicHermiteSpline.py because my iterative versions have not been fully tested yet. I had made those changes a while ago without committing them so my git history was kind of messed up when I did some of this. I'd say that the most recent commit is not 100% ready yet though: see the sed comment.... But I'll modify it once I get the original other files back. Just let me know if you find anything really bad that happened... |
Made iterative versions of _GetLengthHelper and _GetTValueAtLengthHelper. Baseline tests show that they do the same thing as recursive versions but more tests may be needed.
|
ok.... so for some reason git didnt want to tell me about conflicts and was doing some weird things, so this commit history looks really messy. Also something strange happened to all the newlines, so the diffs look pretty bad too.... I think it works though. So let me know if there's any other style things or ways to reconcile this messiness.... |
Made iterative versions of _GetLengthHelper and _GetTValueAtLengthHelper. Baseline tests show that they do the same thing as recursive versions but more tests may be needed.
Hey I got kind of bored and started playing around with Rank Panda again. One thing I found was that I was able to get it to work with python 2.7. So I updated the README to reflect that. I think the other changes I've made were fairly minor (but those were done a while ago...). But I remember finding the python 2.6 download page was kind of difficult, plus its old and people should be using 2.7.