Skip to content
This repository was archived by the owner on Jan 4, 2026. It is now read-only.

Conversation

@assembler-0
Copy link
Owner

@assembler-0 assembler-0 commented Nov 2, 2025

Summary by CodeRabbit

Release Notes

  • New Features

    • Added keyboard keymap management system supporting multiple layouts (US QWERTY, US QWERTZ, Dvorak).
    • Added keymap shell command to view and switch keyboard layouts.
    • Added undefined behavior sanitizer support for improved runtime safety.
  • Bug Fixes

    • Removed SUPER+W window destruction hotkey.
    • Improved keyboard input processing and character translation.
  • Chores

    • Increased build cache size and QEMU virtual CPU allocation for better performance.
    • Enabled silent builds by default.

@coderabbitai
Copy link

coderabbitai bot commented Nov 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces significant build system and driver enhancements. It adds parallel compilation support, increases ccache capacity, and introduces a configurable Clang target triple for cross-compilation. The PS2 keyboard driver undergoes refactoring to externalize keyboard translation logic into a dedicated keymap module supporting multiple keyboard layouts. Undefined Behavior Sanitizer (UBSAN) integration is added with new error handlers and build-time flags. Build configuration defaults shift toward silent builds with debug symbols disabled by default, while a new sanitizer option is introduced. A shell command for keymap management is added, and platform-specific code receives conditional compilation guards.

Poem

Hops of joy through CMake's maze,
Four cores dance in compilation's blaze!
Keyboards speak in many tongues—QWERTY, Dvorak, sweet delight,
UBSAN's safety net catches bugs in flight,
A fuzzy tail-twitch to this build so clean, 🐰✨
The finest kernel this rabbit's ever seen!


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 274270c and 29e6354.

📒 Files selected for processing (15)
  • CMakeLists.txt (1 hunks)
  • arch/x86_64/features/x64.h (1 hunks)
  • cmake/cache.cmake (1 hunks)
  • cmake/ccache.cmake (1 hunks)
  • cmake/configuration.cmake (1 hunks)
  • cmake/flags.cmake (2 hunks)
  • cmake/source.cmake (4 hunks)
  • drivers/PS2.c (3 hunks)
  • drivers/PS2.h (2 hunks)
  • drivers/PS2Keymap.c (1 hunks)
  • drivers/PS2Keymap.h (1 hunks)
  • kernel/etc/Shell.c (4 hunks)
  • kernel/ubsan/Sanitizer.c (1 hunks)
  • kernel/ubsan/Sanitizer.h (1 hunks)
  • vfcompositor/Compositor.c (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@assembler-0 assembler-0 merged commit 721c667 into main Nov 2, 2025
1 of 2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants