chore: fix goboscript file formatter #189
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Fix multi-line
%defineformatter alignment and loop issue🛠️ Issue
📖 Description
format_buffer_inplacefunction insrc/fmt.rsto correctly handle multi-line preprocessor directives (%define ... \).%and end with\) are processed, preventing an infinite loop on single-line directives.✅ Changes made
line.starts_with(b"%") && line.ends_with(b"\\").directive_linesvector, then trim trailing spaces and insert the correct number of spaces before each backslash.iadvances past the entire directive block, preventing infinite loops and hangs.srcbuffer at the end by concatenating modifiedlines, ensuring safe byte-level operations.FmtError) and file read/write patterns.📜 Additional Notes
tests/formatterand existing test suites to confirm no regressions.