feat: add assert_creates_file/3 macro to Igniter.Test#291
Open
lawik wants to merge 1 commit intoash-project:mainfrom
Open
feat: add assert_creates_file/3 macro to Igniter.Test#291lawik wants to merge 1 commit intoash-project:mainfrom
lawik wants to merge 1 commit intoash-project:mainfrom
Conversation
Add a new testing macro that allows users to assert that a file was created and test its contents using a function. This provides a more flexible API for testing file creation compared to the existing assert_creates/3 macro. The new macro supports: - Pipeline-style testing with |> assert_creates_file(path, fn file -> ... end) - Custom assertions on file content using pattern matching and regex - Proper error handling and stack trace preservation
zachdaniel
reviewed
May 29, 2025
| end) | ||
|
|
||
| """ | ||
| defmacro assert_creates_file(igniter, path, fun) do |
Contributor
There was a problem hiding this comment.
should modify existing assert_creates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new testing macro that allows users to assert that a file was created and test its contents using a function. This provides a more flexible API for testing file creation compared to the existing assert_creates/3 macro.
The new macro supports:
Contributor checklist