Skip to content

do not assume https for authorizer address #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronenh merged 1 commit into from
Apr 30, 2025
Merged

do not assume https for authorizer address #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions __tests__/integration/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1790,21 +1790,18 @@ types:
const response = await authorizerClient.DecisionTree({
identityContext: await AnonymousIdentityMapper(),
policyInstance: policyInstance("todo", "todo"),
policyContext: policyContext(),
policyContext: policyContext("todoApp"),
});

const expectedResult = {
path: {
"rebac.check": {
allowed: false,
},
"todoApp.DELETE.todos.__id": { allowed: false },
"todoApp.GET.todos": { allowed: true },
"todoApp.GET.users.__userID": { allowed: true },
"todoApp.POST.todos": { allowed: false },
"todoApp.PUT.todos.__id": { allowed: false },
},
pathRoot: "",
pathRoot: "todoApp",
};

expect(response).toEqual(expectedResult);
Expand All @@ -1830,6 +1827,7 @@ types:
describe("Query", () => {
it("returns the correct data structure", async () => {
const response = await authorizerClient.Query({
identityContext: await AnonymousIdentityMapper(),
query: "x=data",
input: '{"foo": "bar"}',
});
Expand Down
15 changes: 12 additions & 3 deletions lib/authorizer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ import {
QueryRequest,
} from "./types";

const ADDRESS_REGEX = /https?:\/\//;

type AuthorizerConfig = {
authorizerServiceUrl?: string;
tenantId?: string;
Expand Down Expand Up @@ -62,8 +64,15 @@ export class Authorizer {
interceptors.push(traceMessage);
}

const baseServiceUrl =
config.authorizerServiceUrl || "authorizer.prod.aserto.com:8443";
const getServiceUrl = () => {
const baseServiceUrl =
config.authorizerServiceUrl || "authorizer.prod.aserto.com:8443";
const scheme = "https://";

const serviceUrlMatch = baseServiceUrl?.match(ADDRESS_REGEX);
return serviceUrlMatch ? baseServiceUrl : `${scheme}${baseServiceUrl}`;
};

const caFilePath = config.authorizerCertFile || config.caFile;
const baseCaFile = !!caFilePath ? readFileSync(caFilePath) : undefined;

Expand All @@ -75,7 +84,7 @@ export class Authorizer {
};

const baseGrpcTransport = createGrpcTransport({
baseUrl: `https://${baseServiceUrl}`,
baseUrl: getServiceUrl(),
interceptors: interceptors,
nodeOptions: baseNodeOptions,
});
Expand Down
9 changes: 1 addition & 8 deletions lib/processOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,7 @@ export default (
if (!authorizerServiceUrl && res) {
return error(res, "must provide authorizerServiceUrl in option map");
}
let authorizerUrl = `${authorizerServiceUrl}`;
// strip any https:// or http:// prefix since this is a gRPC address
if (authorizerUrl.startsWith("https://")) {
authorizerUrl = authorizerUrl.split("https://")[1]!;
}
if (authorizerUrl.startsWith("http://")) {
authorizerUrl = authorizerUrl.split("http://")[1]!;
}
const authorizerUrl = `${authorizerServiceUrl}`;

// set the authorizer API key
let authorizerApiKey = null;
Expand Down