Open
Conversation
reinterpret_cast on pointers break strict-aliasing rule (-Wstrict-aliasing). Implemented internal function copy_reinterpret_cast that memcpy pointer into type, that can be converted to desired type.
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
This was referenced Apr 14, 2024
Member
|
Thanks @winterheart, I've just tested and this change segfaults one of our userdata_codec.lua tests where these functions are used: |
4 tasks
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jan 8, 2026
Seems to be broken: aseprite/laf#84 (comment) Signed-off-by: Sam James <sam@gentoo.org>
Contributor
Author
|
@dacap It is possible update CXX_STANDARD to C++20 in order to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

reinterpret_cast on pointers break strict-aliasing rule (-Wstrict-aliasing). Implemented internal function copy_reinterpret_cast that memcpy pointer into type, that can be converted to desired type.
Closes aseprite/aseprite#4413
I agree that my contributions are licensed under the MIT License.
You can find a copy of this license at https://opensource.org/licenses/MIT