build: fix linking against shared library#63
Open
mochaaP wants to merge 1 commit intoaseprite:mainfrom
Open
Conversation
Signed-off-by: Zephyr Lykos <self@mochaa.ws>
Member
|
Hi @mochaaP, actually USE_SHARED_FREETYPE and USE_SHARED_HARFBUZZ are flags specified for Aseprite (not for laf). In this case, if we use Skia as a backend, I think we should check the args.gn file of the Skia compilation to check if we can link against the static version of these libraries or use the system ones (these flags are specified when Skia is built with E.g. something like this is done to check if laf is being compiled with the same flags as Skia here. |
Author
|
Surely. I suppose we should also ensure that these two flags are in sync? by the way, it seems static linking is broken if the library is present on the host |
1d90fee to
3f84101
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

When building with shared libraries is enabled in the top-level project (e.g. aseprite here), laf still tries to find the vendored source.
This PR fixes the issue by checking whether a library is specified to use shared libs.
I agree that my contributions are licensed under the MIT License.
You can find a copy of this license at https://opensource.org/licenses/MIT
Signed-off-by: Zephyr Lykos <self@mochaa.ws>