Reading and writing block checksums #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Very strange---some of the tests seem to be randomly hanging on osx. It doesn't seem like it should be related to this PR either, though the last builds on main passed. The ctest runner has a default timeout, it turns out, of 240 seconds so it at least fails with a timeout. |
Collaborator
Author
|
Looks like on the last successful build: and now So that's new, and a likely culprit. Should pin the dependency for now and investigate later. |
This was referenced Jan 15, 2026
Includes low-level emitter option to disable checksumming altogether. A bit of a hack but it's only passed through an internal API for now. gh-106
this is because they expect the output to be binary exact with the reference files, including the block checksum; for now just skip them in this case gh-106
docs: mention libbsd in the readme gh-106
or at least requires some extra fiddling to detect ci: try installing libbsd through homebrew gh-106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic support for this for now; resolves #36 and resolves #106
For now I'm using the MD5 functions from libbsd which should be widely available; could add others later if need be.