Coverage report and test coverage improvements #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lternate file stream refactor: allow passing log config through to the parser test: add test for trace logging of parser events fix: fix output of YAML scalar events that could potentially overflow fix: fix printing of filename in logs when the library is built in a build subdirectory (strip leading ../)
type of the value so it doesn't have to be re-inferred from the raw fy_node test: improve test coverage on value.c
Not as flexible as a custom formatter but that's not a path I want to bother going down right now. test: fixes the logging test to not include line numbers in the expected log output considering what a pain in the ass that would be to maintain
… in some pathologically formatted files test: increase test coverage--these tests exposed some of these bugs
not really noted as a "feature" yet since it's undocumented
Collaborator
Author
|
According to Update: Oh, I just forgot that |
use asdf_event_iterate instead of asdf_parser_parse; the latter is lower-level--it just parses until the next event and returns the event; asdf_event_iterate is basically the same but it automatically frees the previous event on each call
Collaborator
Author
|
Wanted to see if I could build coverage reports in the CI but had some trouble. For now I'd like to just get this merged for the fixes it includes and can come back to the CI question later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spent a little time over the holidays adding more tests and improving overall coverage. Fixed a few bugs in the process and added new log-formatting features to boot.