feat: enhance USB backend error handling with specific permission exception#124
Merged
robberwick merged 1 commit intoarvydas:release/2.0-devfrom Feb 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/blinkstick/backends/unix_like.py:72
- [nitpick] The error message could be more informative. Consider adding details on how to add a udev rule or a link to documentation.
"Permission denied accessing USB backend. Does a udev rule need to be added?"
src/blinkstick/backends/unix_like.py:68
- Ensure that the new error handling behavior is covered by tests, specifically for permission issues.
except usb.core.USBError as e:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes an important update to the
get_attached_blinkstick_devicesfunction in thesrc/blinkstick/backends/unix_like.pyfile. The changes improve error handling by adding a try-except block to catch USB errors and provide more specific error messages, and signposting the user towards udev rules as a posible remediation.Error handling improvements:
usb.core.USBErrorexceptions.USBBackendNotAvailableexception when there are permission issues