Some fixups, bug fixes, and add IPv6 and unix socket type support. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheako
force-pushed
the
firstpull
branch
8 times, most recently
from
5091937 to
ec6ce61
Compare
|
Hi @cheako thanks for making these changes. One thing I noticed is that I'm getting a core dump when I targeting my localhost like this: "./htstress -n 1 -c 1 -t 1 localhost:80". The crash happens at line #454 I think the reason for that is the way how you parse hostname/port. |
Author
|
You shouldn't get to 454 without any '/'. 454 copies the text from ':' to '/' exclusively. This could be a name like "http" or a number in string form like "80". The important part is the inclusion of a null terminator that strndup() adds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.