Skip to content

Conversation

@MounirDhahri
Copy link
Member

This PR resolves []

Description

This PR adds a skill on how to write tests to Eigen. The skill needs to be invoked to take effect

Screenshot 2026-01-05 at 17 47 13

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • add testing skill - mounir

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Jan 5, 2026
Copy link
Member

@anandaroop anandaroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising!

Out of curiosity, did Claude manage to one-shot the test once you gave it the skill? Or did you still have to steer it somewhat?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: What's this file — is it necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually asked claude about it and it said useful for sharing or usage in the browser for Entreprise plans.

@@ -0,0 +1,292 @@
# Copilot Context for Eigen Testing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Maybe a more generic name for this file? (I.e. not Copilot-specific)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@MounirDhahri
Copy link
Member Author

Fwiw, I don't intend to merge this PR and it's instead just for learning purposes. It does however have potential

I found that the skill was not being picked up correctly before this.
feat: tweaks for linting and scrolling

fix: normalize skill name

Weirdly, the skill-creator skill doesn't follow Anthropic's own advice:
https://platform.claude.com/docs/en/agents-and-tools/agent-skills/best-practices#skill-structure

I had to fix that in order to have the new skill correctly invoke
the existing eigen-testing skill.

refactor: vast simplification via Opus and some manual tweaks

refactor: manual tweaks
Copy link
Member

@anandaroop anandaroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding my notes from experimenting with a new creating-screens skill.

I tried two approaches:

Both approaches worked more or less.

But I note that the skill-creator created a very verbose set of documents with redundant code snippets, references, templates. I was concerned about context bloat so I asked Opus to edit the skill docs with an emphasis on "concision and clarity" and it dropped from ~1500 lines to ~150, with no obvious difference in performance.

It also failed to follow some of Anthropic's own best practice advice (start small, don't overexplain, follow naming convention for skill names).

But it was a good way to get familiar with Skill possibilities. My gut feeling is that the skill-creator is great for getting your feet wet, but writing artisanally with the best practice advice might result in equal or better quality with fewer tokens.

Comment on lines +8 to +17
Use this checklist to track your work:

```md
- [ ] Confirm the component/folder name and the desired route
- [ ] Create the correct type of screen
- [ ] Write a test for the new screen (using `/eigen-testing` skill)
- [ ] Ensure the test passes (`yarn test [test file]`)
- [ ] Run linter (`yarn lint [pending files]`)
- [ ] Run formatter (`yarn prettier -w [pending files]`)
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the skill-creator did its thing, I added this checklist, based on this advice:

https://platform.claude.com/docs/en/agents-and-tools/agent-skills/best-practices#use-workflows-for-complex-tasks

Works well! And the first bullet will result in CC soliciting answers from you via its new-ish form capability.

@@ -0,0 +1,125 @@
---
name: eigen-testing
Copy link
Member

@anandaroop anandaroop Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to change the name from "Eigen Testing" to this.

That's actually what the spec requires, yet the skill-creator doesn't follow it 🤷🏽

Without this I couldn't get the new creating-screens skill to correctly invoke this skill. (Having skills invoke other skills is a handy feature)

@MounirDhahri
Copy link
Member Author

Thanks for adding this @anandaroop and digging deeper in skills creation.
It's crazy how big the ouput was using skill-creator but somehow, it's maybe expected based on how chatty the agent can be. It's a good thing to keep on mind for the future.

@MounirDhahri MounirDhahri changed the title chore: add testing skill chore: try claude skills Jan 7, 2026
anandaroop added a commit that referenced this pull request Jan 7, 2026
This was one-shotted by Claude using the "creating-screens" agent skill
that we tinkered with in #13126
anandaroop added a commit that referenced this pull request Jan 8, 2026
This was one-shotted by Claude using the "creating-screens" agent skill
that we tinkered with in #13126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants