-
Notifications
You must be signed in to change notification settings - Fork 594
chore: try claude skills #13126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: try claude skills #13126
Conversation
anandaroop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks promising!
Out of curiosity, did Claude manage to one-shot the test once you gave it the skill? Or did you still have to steer it somewhat?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: What's this file — is it necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually asked claude about it and it said useful for sharing or usage in the browser for Entreprise plans.
| @@ -0,0 +1,292 @@ | |||
| # Copilot Context for Eigen Testing | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Maybe a more generic name for this file? (I.e. not Copilot-specific)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea
|
Fwiw, I don't intend to merge this PR and it's instead just for learning purposes. It does however have potential |
I found that the skill was not being picked up correctly before this.
feat: tweaks for linting and scrolling fix: normalize skill name Weirdly, the skill-creator skill doesn't follow Anthropic's own advice: https://platform.claude.com/docs/en/agents-and-tools/agent-skills/best-practices#skill-structure I had to fix that in order to have the new skill correctly invoke the existing eigen-testing skill. refactor: vast simplification via Opus and some manual tweaks refactor: manual tweaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding my notes from experimenting with a new creating-screens skill.
I tried two approaches:
- Artisanal , from scratch following best practice advice
- Skill-creator, Using Anthropic's
skill-creatorskill to bootstrap my own new skill- https://github.com/anthropics/skills/blob/main/skills/skill-creator/SKILL.md
- That appraoch plus some manual tweaks is what I'm committing here.
Both approaches worked more or less.
But I note that the skill-creator created a very verbose set of documents with redundant code snippets, references, templates. I was concerned about context bloat so I asked Opus to edit the skill docs with an emphasis on "concision and clarity" and it dropped from ~1500 lines to ~150, with no obvious difference in performance.
It also failed to follow some of Anthropic's own best practice advice (start small, don't overexplain, follow naming convention for skill names).
But it was a good way to get familiar with Skill possibilities. My gut feeling is that the skill-creator is great for getting your feet wet, but writing artisanally with the best practice advice might result in equal or better quality with fewer tokens.
| Use this checklist to track your work: | ||
|
|
||
| ```md | ||
| - [ ] Confirm the component/folder name and the desired route | ||
| - [ ] Create the correct type of screen | ||
| - [ ] Write a test for the new screen (using `/eigen-testing` skill) | ||
| - [ ] Ensure the test passes (`yarn test [test file]`) | ||
| - [ ] Run linter (`yarn lint [pending files]`) | ||
| - [ ] Run formatter (`yarn prettier -w [pending files]`) | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the skill-creator did its thing, I added this checklist, based on this advice:
Works well! And the first bullet will result in CC soliciting answers from you via its new-ish form capability.
| @@ -0,0 +1,125 @@ | |||
| --- | |||
| name: eigen-testing | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to change the name from "Eigen Testing" to this.
That's actually what the spec requires, yet the skill-creator doesn't follow it 🤷🏽
Without this I couldn't get the new creating-screens skill to correctly invoke this skill. (Having skills invoke other skills is a handy feature)
|
Thanks for adding this @anandaroop and digging deeper in skills creation. |
This was one-shotted by Claude using the "creating-screens" agent skill that we tinkered with in #13126
This was one-shotted by Claude using the "creating-screens" agent skill that we tinkered with in #13126
This PR resolves []
Description
This PR adds a skill on how to write tests to Eigen. The skill needs to be invoked to take effect
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.