feat(DIAM-69): Send analytics event when tapping Complete My Profile #13110
+42
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanaeHijaz
previously approved these changes
Jan 5, 2026
anandaroop
reviewed
Jan 5, 2026
Member
anandaroop
left a comment
anandaroop
left a comment
There was a problem hiding this comment.
Lgtm just one Apostrophe Cop 👮🏽♂️ comment below…
src/app/Scenes/Activity/components/CollectorUpdateNotification.tsx
Outdated
Show resolved
Hide resolved
iskounen
previously approved these changes
Jan 5, 2026
lilyfromseattle
dismissed stale reviews from iskounen, JanaeHijaz, and gkartalis
via
d05c868
Contributor
MounirDhahri
reviewed
Jan 6, 2026
Comment on lines
+112
to
+113
| context_module: ContextModule.collectorProfileCard, | ||
| context_screen_owner_type: OwnerType.profile, |
Member
There was a problem hiding this comment.
I would have assumed this to be the Activity screen
Contributor
Author
There was a problem hiding this comment.
I was going off of this: https://github.com/artsy/cohesion/blob/2309c7ee5b4ff2d872c235c709e9f8418b697e8d/src/Schema/Events/Tap.ts#L1469 but I can change if that's not correct
Member
There was a problem hiding this comment.
I think that was most likely for the other "CompleMyProfile" that we used to have (maybe still do) inside the profile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves DIAM-69
Description
The ticket description said this story was to track clicks on the "Complete Profile" button, which already had tracking implemented. However in the link from cohesion there was a comment saying
A user taps on the complete your profile prompt within the activity panelso that's what I added.PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.