Add support for nace revision 2.1#490
Add support for nace revision 2.1#490kat-star-me wants to merge 3 commits intoarthurdejong:masterfrom
Conversation
|
Hi @kat-star-me, Thanks for providing this. I see this mostly consists of a new data file (the Do you think it is a good idea to just replace the 2.0 NACE data file with the 2.1 version? An alternative would be to have a single implementation and some way to switch between versions 2.0 and 2.1 but that mostly depends on whether it is a good idea to keep the 2.0 implementation around at all. |
|
Hi @arthurdejong We could create submodules for 2.0 and 2.1 in nace (so stdnum.nace.v2.1 and stdnum.nace.v2.0) and set one of them to be default for a cleaner structure. |
Added structure to make rev2.1 and rev2.0 submodules of nace. 2.1 is default, but rev2.0 remains accessible per address
|
Hi @arthurdejong You can still import nace and use it as before. It will forward the calls to nace.v2_1 for now.. but people would be able to use nace.v2_0 if they still needed the old classifications. Let me know if this is a workable solution for you. If not, and given the fact that we're already in November, it's probably safe to simply update the data to 2.1 and remove 2.0. regards |
|
Hi @kat-star-me, Sorry it took a bit but going back and forth I've decided to keep one Python module for NACE and add an extra argument to the functions to select a revision. I did change the default to use revision 2.1. Thanks for your contribution. It was merged as 2cf475c. |
|
Great, thanks! |
The EU has recently released the new nace classification version 2.1. I have added a new module to support 2.1 (rather than overwriting the existing one for revision 2, as this is probably still widely used).
The data was collected here: https://showvoc.op.europa.eu/#/datasets/ESTAT_Statistical_Classification_of_Economic_Activities_in_the_European_Community_Rev._2.1._%28NACE_2.1%29/downloads
I am attaching the script I used for reformatting this into the numdb format.
prepare_nace21_dat.py
The file provided contains the label in all European languages, a future improvement could be to support for mutliple languages for the nace descriptions.