Removed unnecessary global IMPORTS list and added quotations to CSV generation#20
Open
born2c0de wants to merge 2 commits intoarmbues:masterfrom
Open
Removed unnecessary global IMPORTS list and added quotations to CSV generation#20born2c0de wants to merge 2 commits intoarmbues:masterfrom
born2c0de wants to merge 2 commits intoarmbues:masterfrom
Conversation
Replaced with sys.modules https://docs.python.org/2/library/sys.html#sys.modules
Fixes CSV reading issues (with appropriate quotes) that arise when values (such as filenames) contains spaces.
born2c0de
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced with sys.modules
https://docs.python.org/2/library/sys.html#sys.modules
Adding quoting for non-numeric data to prevent CSV reading issues when filenames contain spaces.