add allwinner: a523: Support SPI controllers patch series
#9124
+520
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvilOlaf
requested review from
AGM1968,
JohnTheCoolingFan,
PanderMusubi,
TheSnowfield,
Tonymac32,
chraac,
igorpecovnik,
janprunk,
krachlatte,
pyavitz,
schwar3kat,
sgjava and
teknoid
as code owners
Contributor
WalkthroughThis pull request adds support for Allwinner A523 SPI controllers by introducing a new kernel patch. The changes extend device-tree bindings, modify the SPI driver to recognize new A523 SoC variants, and add device-tree nodes for three SPI controllers with corresponding pinctrl configurations and flash storage support. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
02
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
patch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patchpatch/kernel/archive/sunxi-6.18/series.conf
🧰 Additional context used
🧠 Learnings (15)
📓 Common learnings
Learnt from: EvilOlaf
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-12-19T13:56:45.124Z
Learning: When reviewing kernel or u-boot version bump PRs in the Armbian build system, check if patches existed in previous kernel version directories (e.g., sunxi-6.12, sunxi-6.13) before describing them as new features. If a patch and the majority of its contents existed previously with no major functionality changes, focus the review on the actual changes: the version bump itself and patch compatibility adjustments. Don't describe existing patches being ported/maintained across versions as new features or drivers—this is misleading. The patches are existing code being re-aligned to work with the new upstream version.
Learnt from: EvilOlaf
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-12-17T05:09:02.306Z
Learning: In the Armbian build system, kernel patches (e.g., in patch/kernel/archive/sunxi-6.18/patches.armbian/) contain device tree overlays and other code that have existed for years and are maintained/ported across kernel versions. When reviewing PRs that modify these patch files, focus on the actual changes being made (e.g., Makefile fixes, new additions) rather than reviewing the entire existing content within the patch as if it were new code. The patch file contents are existing, stable code unless explicitly modified in the PR diff.
Learnt from: EvilOlaf
Repo: armbian/build PR: 9096
File: patch/kernel/archive/sunxi-6.18/patches.armbian/arm64-dts-sun50i-h616-add-overlays.patch:4-5
Timestamp: 2025-12-17T15:46:22.709Z
Learning: In Armbian kernel patches, when patches are renamed or reorganized, the old Subject line may be intentionally preserved in the patch header (as a second Subject line) for archival/historical purposes to document the previous patch name. This is an Armbian-specific practice for tracking patch evolution and should not be flagged as an error when the maintainer has intentionally included it for documentation.
Learnt from: EvilOlaf
Repo: armbian/build PR: 8968
File: patch/u-boot/u-boot-sunxi/arm64-dts-sun50i-h6-orangepi.dtsi-Rollback-r_rsb-to-r_i2c.patch:36-36
Timestamp: 2025-11-20T18:20:11.985Z
Learning: The rewrite-patches tool (REWRITE_PATCHES=yes) in the Armbian build system can inadvertently introduce semantic changes when the u-boot/kernel git base revision differs from expected state. The tool applies patches, commits them, and re-exports them using git format-patch, which can cause the re-exported patch to reflect the base revision's state rather than preserving the original patch intent. This is particularly problematic for device tree changes like interrupt specifications. The tool currently lacks validation mechanisms to detect such semantic drift, and affected patches must be manually corrected after rewriting.
📚 Learning: 2025-12-17T05:09:02.306Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-12-17T05:09:02.306Z
Learning: In the Armbian build system, kernel patches (e.g., in patch/kernel/archive/sunxi-6.18/patches.armbian/) contain device tree overlays and other code that have existed for years and are maintained/ported across kernel versions. When reviewing PRs that modify these patch files, focus on the actual changes being made (e.g., Makefile fixes, new additions) rather than reviewing the entire existing content within the patch as if it were new code. The patch file contents are existing, stable code unless explicitly modified in the PR diff.
Applied to files:
patch/kernel/archive/sunxi-6.18/series.confpatch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patch
📚 Learning: 2025-12-19T13:56:45.124Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-12-19T13:56:45.124Z
Learning: When reviewing kernel or u-boot version bump PRs in the Armbian build system, check if patches existed in previous kernel version directories (e.g., sunxi-6.12, sunxi-6.13) before describing them as new features. If a patch and the majority of its contents existed previously with no major functionality changes, focus the review on the actual changes: the version bump itself and patch compatibility adjustments. Don't describe existing patches being ported/maintained across versions as new features or drivers—this is misleading. The patches are existing code being re-aligned to work with the new upstream version.
Applied to files:
patch/kernel/archive/sunxi-6.18/series.confpatch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patch
📚 Learning: 2025-12-17T15:46:22.709Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 9096
File: patch/kernel/archive/sunxi-6.18/patches.armbian/arm64-dts-sun50i-h616-add-overlays.patch:4-5
Timestamp: 2025-12-17T15:46:22.709Z
Learning: In Armbian kernel patches, when patches are renamed or reorganized, the old Subject line may be intentionally preserved in the patch header (as a second Subject line) for archival/historical purposes to document the previous patch name. This is an Armbian-specific practice for tracking patch evolution and should not be flagged as an error when the maintainer has intentionally included it for documentation.
Applied to files:
patch/kernel/archive/sunxi-6.18/series.confpatch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patch
📚 Learning: 2025-11-20T18:20:11.985Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 8968
File: patch/u-boot/u-boot-sunxi/arm64-dts-sun50i-h6-orangepi.dtsi-Rollback-r_rsb-to-r_i2c.patch:36-36
Timestamp: 2025-11-20T18:20:11.985Z
Learning: The rewrite-patches tool (REWRITE_PATCHES=yes) in the Armbian build system can inadvertently introduce semantic changes when the u-boot/kernel git base revision differs from expected state. The tool applies patches, commits them, and re-exports them using git format-patch, which can cause the re-exported patch to reflect the base revision's state rather than preserving the original patch intent. This is particularly problematic for device tree changes like interrupt specifications. The tool currently lacks validation mechanisms to detect such semantic drift, and affected patches must be manually corrected after rewriting.
Applied to files:
patch/kernel/archive/sunxi-6.18/series.confpatch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patch
📚 Learning: 2025-12-13T11:39:08.046Z
Learnt from: pyavitz
Repo: armbian/build PR: 9058
File: patch/u-boot/legacy/u-boot-spacemit-k1/003-SpacemiT-K1X-Fixups.patch:28-67
Timestamp: 2025-12-13T11:39:08.046Z
Learning: In the Armbian build system for SpacemiT U-Boot patches (patch/u-boot/legacy/u-boot-spacemit-k1/), alignment with mainline U-Boot behavior is prioritized. For example, in boot mode handling, leaving devnum unchanged in the default case (when devtype is cleared) follows mainline conventions rather than explicitly clearing it to handle edge cases.
Applied to files:
patch/kernel/archive/sunxi-6.18/series.confpatch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patch
📚 Learning: 2025-03-31T22:20:48.475Z
Learnt from: rpardini
Repo: armbian/build PR: 8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:76-86
Timestamp: 2025-03-31T22:20:48.475Z
Learning: For the Armbian build project, maintaining consistency with existing patches across U-Boot versions (such as between 2025.01 and 2025.04) is prioritized over refactoring individual patches for code improvements.
Applied to files:
patch/kernel/archive/sunxi-6.18/series.conf
📚 Learning: 2025-03-31T22:20:41.849Z
Learnt from: rpardini
Repo: armbian/build PR: 8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:73-75
Timestamp: 2025-03-31T22:20:41.849Z
Learning: When porting patches between U-Boot versions (like from 2025.01 to 2025.04), rpardini prefers to maintain patches as-is rather than introducing refactoring changes, even when potential improvements are identified. This approach prioritizes consistency and reduces the risk of introducing new issues.
Applied to files:
patch/kernel/archive/sunxi-6.18/series.conf
📚 Learning: 2025-07-23T07:30:52.265Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 8417
File: config/boards/orangepi5pro.csc:57-58
Timestamp: 2025-07-23T07:30:52.265Z
Learning: In the Armbian build system, BOOTPATCHDIR can contain board-specific subdirectories (e.g., board_orangepi5pro) for applying patches to specific boards only. The framework automatically checks if such board-specific subdirectories exist for the board being built and applies those patches accordingly.
Applied to files:
patch/kernel/archive/sunxi-6.18/series.conf
📚 Learning: 2025-09-14T11:37:35.089Z
Learnt from: amazingfate
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:65-72
Timestamp: 2025-09-14T11:37:35.089Z
Learning: In the Armbian build system, patch directories referenced in BOOTPATCHDIR and KERNELPATCHDIR configurations can be non-existent without causing build failures. Empty patch directories are also ignored by git, so missing patch directories should not be flagged as errors during code review.
Applied to files:
patch/kernel/archive/sunxi-6.18/series.conf
📚 Learning: 2025-09-11T06:06:52.328Z
Learnt from: SuperKali
Repo: armbian/build PR: 8608
File: lib/functions/compilation/patch/drivers_network.sh:361-363
Timestamp: 2025-09-11T06:06:52.328Z
Learning: For the RTW88 SDIO RF path detection fix patch (004-rtw88-sdio-rf-path-detection-fix.patch), SuperKali prefers using exact version matching (eq 6.1 || eq 6.16) rather than range checks, as the patch has only been tested on those specific kernel versions and may be mainstreamed soon.
Applied to files:
patch/kernel/archive/sunxi-6.18/series.conf
📚 Learning: 2025-08-02T14:59:28.145Z
Learnt from: amazingfate
Repo: armbian/build PR: 8453
File: lib/functions/compilation/patch/drivers_network.sh:213-216
Timestamp: 2025-08-02T14:59:28.145Z
Learning: The wireless driver patches wireless-rtl8812au-Fix-6.16.patch, wireless-rtl8811cu-Fix-6.16.patch, and wireless-rtl88x2bu-Fix-6.16.patch in the Armbian build system are backward compatible and can be applied unconditionally without version checks, even though they're named for 6.16+ fixes.
Applied to files:
patch/kernel/archive/sunxi-6.18/series.conf
📚 Learning: 2025-06-14T05:53:10.627Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 8298
File: extensions/https_proxy.sh:1-9
Timestamp: 2025-06-14T05:53:10.627Z
Learning: Armbian build framework extensions are NOT designed to run standalone but are called by the supervisor. The framework provides environment variables like USERPATCHES_PATH and SDCARD, and commands are executed with protection via run_host_command_logged and chroot_sdcard functions that use bash -e -o pipefail.
Applied to files:
patch/kernel/archive/sunxi-6.18/series.conf
📚 Learning: 2025-10-22T07:51:53.015Z
Learnt from: igorpecovnik
Repo: armbian/build PR: 8789
File: config/kernel/linux-sunxi64-edge.config:839-839
Timestamp: 2025-10-22T07:51:53.015Z
Learning: In Armbian's wireless driver configuration, CONFIG_RK_WIFI_DEVICE_* options are Rockchip-specific device registration settings, while CONFIG_WLAN_UWE* are the actual cross-platform driver modules for UWE5622 wireless chips. The UWE5622 chip (manufactured by Unisoc/Spreadtrum) is used on multiple Allwinner boards including Orange Pi Zero 2/2W/3 and Orange Pi 3 LTS, so CONFIG_WLAN_UWE5621/5622 along with Unisoc infrastructure options (CONFIG_SPARD_WLAN_SUPPORT, CONFIG_SC23XX, CONFIG_UNISOC_WIFI_PS, CONFIG_WCN_BSP_DRIVER_BUILDIN) are correct in sunxi64 kernel configs.
Applied to files:
patch/kernel/archive/sunxi-6.18/series.confpatch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patch
📚 Learning: 2025-09-14T05:23:42.991Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 8632
File: config/sources/families/include/rockchip64_common.inc:327-334
Timestamp: 2025-09-14T05:23:42.991Z
Learning: In the Armbian build system for Rockchip boards, SPI flash consistently maps to /dev/mtd0, so hard-coding this device path in flashcp commands is acceptable and based on hardware conventions rather than being a bug.
Applied to files:
patch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patch
🔇 Additional comments (6)
patch/kernel/archive/sunxi-6.18/series.conf (1)
410-411: LGTM!The new backport patch entry is correctly placed in the backports section and follows the existing naming convention with numeric prefix.
patch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patch (5)
24-53: DT binding additions look correct.The binding updates for
allwinner,sun55i-a523-spiand the-dbivariant follow the existing patterns in the yaml file.
64-99: Pinctrl definitions are well-structured.The SPI0 pin configurations properly use
/omit-if-no-ref/and include helpful comments about eMMC conflicts for hold and wp pins.
112-178: SPI controller nodes are properly defined.The four SPI controllers (spi0, spi1, spi2, r_spi0) follow correct device tree conventions with sequential register addresses, IRQs, and DMA channels. All are disabled by default, following best practices for board-specific enablement.
448-461: SPI flash configuration for Orange Pi 4A looks reasonable.The SPI NOR flash is configured with a conservative 20MHz frequency and appropriate pinctrl. The
vcc-supply = <®_cldo1>reference should exist in the board's PMIC configuration.
490-515: Driver changes are correct with good documentation.The A523 SPI controller reuses the R329 configuration, and the inline comment (lines 505-509) clearly explains the hardware difference regarding the combined RX buffer + FIFO counter. This aligns with the PR description about the A523's register changes.
Comment on lines
+5
to
+10
| Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml | ||
| arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | ||
| arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi.orig | ||
| arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dts | ||
| arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dts.orig | ||
| drivers/spi/spi-sun6i.c |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# First, verify the patch file exists and check for .orig file modifications
echo "=== Checking patch content for .orig file modifications ==="
patch_file="patch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patch"
if [ -f "$patch_file" ]; then
echo "Patch file found. Checking for .orig file hunks..."
grep -c "^+++ .*\.orig" "$patch_file" || echo "No .orig file modifications found"
echo ""
echo "=== Listing all modified files in this patch ==="
grep "^+++ b/" "$patch_file" | sed 's/^+++ b\///' | sort | uniq
echo ""
echo "=== Checking for .orig pattern in file list ==="
grep "^+++ b/.*\.orig" "$patch_file" | sed 's/^+++ b\///'
else
echo "Patch file not found!"
fi
echo ""
echo "=== Checking if other patches in the same directory modify .orig files ==="
patches_dir="patch/kernel/archive/sunxi-6.18/patches.backports"
if [ -d "$patches_dir" ]; then
count=0
for f in "$patches_dir"/*.patch; do
if [ -f "$f" ] && grep -q "^+++ .*\.orig" "$f" 2>/dev/null; then
echo "$(basename "$f")"
((count++))
fi
done
echo "Total patches with .orig modifications: $count"
else
echo "Directory not found: $patches_dir"
fiRepository: armbian/build
Length of output: 860
🏁 Script executed:
#!/bin/bash
patch_file="patch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patch"
echo "=== Examining .orig file modification hunks ==="
# Extract hunks for .orig files
awk '/^--- a.*\.orig/{flag=1; section=$0} /^--- a/ && !/\.orig/{if(flag) flag=0} flag' "$patch_file" | head -200
echo ""
echo "=== Comparing size of changes to .orig vs non-.orig files ==="
echo "Lines added to sun55i-a523.dtsi:"
grep -c "^++" "$patch_file" | head -1
echo "Lines added to sun55i-a523.dtsi.orig:"
awk '/^--- a.*sun55i-a523\.dtsi\.orig/{flag=1} /^--- a/ && !/sun55i-a523\.dtsi\.orig/{flag=0} flag' "$patch_file" | grep "^++" | wc -l
echo ""
echo "Lines added to sun55i-t527-orangepi-4a.dts:"
awk '/^--- a.*sun55i-t527-orangepi-4a\.dts$/{flag=1} /^--- a/ && !/sun55i-t527-orangepi-4a\.dts$/{flag=0} flag' "$patch_file" | grep "^++" | wc -l
echo "Lines added to sun55i-t527-orangepi-4a.dts.orig:"
awk '/^--- a.*sun55i-t527-orangepi-4a\.dts\.orig/{flag=1} /^--- a/ && !/sun55i-t527-orangepi-4a\.dts\.orig/{flag=0} flag' "$patch_file" | grep "^++" | wc -l
echo ""
echo "=== First 50 lines of sun55i-a523.dtsi.orig hunk ==="
awk '/^--- a.*sun55i-a523\.dtsi\.orig/{flag=1; next} /^--- a/{if(flag) exit} flag' "$patch_file" | head -50Repository: armbian/build
Length of output: 6513
The patch includes modifications to .orig files which should be excluded.
The patch modifies sun55i-a523.dtsi.orig and sun55i-t527-orangepi-4a.dts.orig. These are backup/artifact files that should not be committed to the kernel tree. The .orig file for sun55i-a523.dtsi includes ~120+ lines of unrelated thermal configuration (thermal sensor nodes, cooling-cells, thermal-zones) that appear to be artifacts from the patch generation process. These files will cause issues when applying the patch to a clean kernel tree.
Regenerate the patch to exclude the .orig file modifications.
🤖 Prompt for AI Agents
In
patch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patch
around lines 5 to 10, the patch incorrectly includes .orig backup files
(sun55i-a523.dtsi.orig and sun55i-t527-orangepi-4a.dts.orig) which are unrelated
artifacts; regenerate the patch without these files by removing the .orig
entries from the commit/diff and re-creating the patch from a clean working tree
(use git add only the intended files, git commit, then git format-patch or git
diff --staged), confirm the regenerated patch contains only the target files,
and validate with git apply --check before submitting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add this series as a single patch: https://patchwork.kernel.org/project/linux-arm-kernel/cover/20251221110513.1850535-1-wens@kernel.org/
How Has This Been Tested?
Checklist:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.