Skip to content

BTRFS: move btrfs support packages from additional to main package list#8888

Merged
igorpecovnik merged 1 commit intomainfrom
btrfs
Nov 8, 2025
Merged

BTRFS: move btrfs support packages from additional to main package list#8888
igorpecovnik merged 1 commit intomainfrom
btrfs

Conversation

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Nov 7, 2025

Description

This will ensure support is also present in minimal images by default.

Fixes armbian/configng#663
Closes armbian/configng#662

How Has This Been Tested?

grep -R btrfs
trixie/main/packages:btrfs-progs
oracular/main/packages:btrfs-progs
buster/main/packages:btrfs-progs
plucky/main/packages:btrfs-progs
forky/main/packages:btrfs-progs
bookworm/main/packages:btrfs-progs
sid/main/packages:btrfs-progs
common/main/packages:btrfs-progs
noble/main/packages:btrfs-progs

Won't be tested. We are moving one basic package from full CLI to minimal.

Checklist:

  • My code follows the style guidelines of this project

Summary by CodeRabbit

  • Chores
    • Reorganized package configuration by consolidating btrfs-progs to the common base package set across all distributions, removing it from distribution-specific additional packages.

This will ensure support is also present in minimal images by default.
@github-actions github-actions bot added 11 Milestone: Fourth quarter release size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Nov 7, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025

Walkthrough

This change reorganizes the btrfs-progs package specification across distribution configurations. The package is added to the common main packages list and simultaneously removed from additional packages lists in multiple distribution variants (common, noble, sid, trixie).

Changes

Cohort / File(s) Summary
Package addition to common main
config/cli/common/main/packages
Added btrfs-progs entry to the main package list
Package removal from additional lists
config/cli/common/main/packages.additional, config/cli/noble/main/packages.additional, config/cli/sid/main/packages.additional, config/cli/trixie/main/packages.additional
Removed btrfs-progs entry from additional packages across all distribution variants

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple configuration reorganization with repetitive pattern (same package removal across multiple variant files)
  • No logic changes or behavioral modifications; pure package list reordering
  • Low risk given straightforward nature of changes

Suggested reviewers

  • iav
  • chraac
  • rpardini

Poem

A file hops here, a file hops there, 🐰
Moving btrfs-progs with utmost care,
From "additional" lists it takes its flight,
To the common main, where it sits just right! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive While the PR moves btrfs-progs to main packages as intended to address issue #663, the linked issue describes a boot failure on BTRFS installs that may require additional fixes beyond package availability. Verify that moving btrfs-progs to the main package list resolves the boot failure reported in issue #663, as the issue may involve additional bootloader configuration needs beyond package inclusion.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately and clearly describes the main change: moving btrfs-progs from additional to main package lists across multiple distributions.
Out of Scope Changes check ✅ Passed All changes are in-scope: the PR adds btrfs-progs to main package lists and removes it from additional lists across all specified distributions, directly addressing the stated objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch btrfs

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4a3b8a1 and af957fa.

📒 Files selected for processing (5)
  • config/cli/common/main/packages (1 hunks)
  • config/cli/common/main/packages.additional (0 hunks)
  • config/cli/noble/main/packages.additional (0 hunks)
  • config/cli/sid/main/packages.additional (0 hunks)
  • config/cli/trixie/main/packages.additional (0 hunks)
💤 Files with no reviewable changes (4)
  • config/cli/noble/main/packages.additional
  • config/cli/common/main/packages.additional
  • config/cli/trixie/main/packages.additional
  • config/cli/sid/main/packages.additional
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: tabrisnet
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-08-30T06:56:33.372Z
Learning: In Armbian kernel configuration, the BTRFS configuration logic preserves existing settings (whether built-in 'y' or module 'm') and only sets BTRFS_FS to module when it was previously disabled or not set, achieving "allow but not require" flexibility while maintaining backward compatibility.
Learnt from: tabrisnet
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-10-24T04:46:22.901Z
Learning: In lib/functions/rootfs/rootfs-create.sh, the FIXME comment about mmdebstrap usage with --aptopt is a future note related to PR #8785, which hasn't been merged yet.
🔇 Additional comments (1)
config/cli/common/main/packages (1)

4-4: ✓ Addition correctly positioned and alphabetically sorted.

The btrfs-progs package is properly inserted at line 4 in alphabetical order between bc and console-setup. This aligns with the PR objective to ensure BTRFS support is available in minimal images by default, addressing issue #663.

Warning

Tools execution failed with the following error:

Failed to run tools: Stream setup permanently failed: 14 UNAVAILABLE: read ECONNRESET


Comment @coderabbitai help to get the list of available commands and usage tips.

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Nov 8, 2025
@igorpecovnik igorpecovnik merged commit 97924fb into main Nov 8, 2025
1 check passed
@igorpecovnik igorpecovnik deleted the btrfs branch November 8, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

[Bug]: BTRFS Install does not boot [Bug]: BTRFS Install fails due to missing btrfs-progs package on Trixie

1 participant