board: youyeetoo-r1: correct minor typo on the config#8817
board: youyeetoo-r1: correct minor typo on the config#8817SuperKali merged 1 commit intoarmbian:mainfrom
Conversation
WalkthroughThis pull request modifies the Youyeetoo R1 v3 board configuration file, implementing several refinements: correcting capitalization in comments and descriptive text, reordering boot device precedence to prioritize mmc0 over nvme and mmc1, and refactoring the Wi-Fi driver (rtw89_8852be) configuration logic. The changes introduce an early-exit pattern for branch conditionals and extract driver tweaks into a dedicated Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes The changes are focused on a single board configuration file with mixed modifications: minor formatting adjustments, capitalization corrections, boot order reordering, and logic refactoring with an early-exit pattern. While there is some structural reorganization, the changes follow a consistent pattern and the logic modifications are straightforward. The diff is contained and relatively homogeneous in nature. Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ This PR has been reviewed and approved — all set for merge! |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
config/boards/youyeetoo-r1-v3.csc(3 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-06-04T23:45:38.860Z
Learnt from: djurny
PR: armbian/build#8272
File: config/bootscripts/boot-mvebu.cmd:182-186
Timestamp: 2025-06-04T23:45:38.860Z
Learning: In config/bootscripts/boot-mvebu.cmd, the `fdtfile` variable is mandatory for booting and is pre-set by U-Boot, but can be overridden via armbianEnv.txt. If `fdtfile` is empty, the subsequent device tree file search logic will eventually fail and trigger the critical error "Cannot find DT!" with proper error handling.
Applied to files:
config/boards/youyeetoo-r1-v3.csc
📚 Learning: 2025-09-12T21:44:09.061Z
Learnt from: Grippy98
PR: armbian/build#8624
File: config/boards/sk-am62p.conf:8-8
Timestamp: 2025-09-12T21:44:09.061Z
Learning: For TI K3 family boards in Armbian, BOOT_FDT_FILE uses .dts extension (not .dtb) as the standard convention. The build system handles this correctly by automatically compiling .dts to .dtb during kernel build and using the BOOT_FDT_FILE value directly in bootloader configurations.
Applied to files:
config/boards/youyeetoo-r1-v3.csc
🔇 Additional comments (2)
config/boards/youyeetoo-r1-v3.csc (2)
38-38: LGTM - Comment and formatting cleanup.These comment and formatting adjustments have no functional impact.
Also applies to: 44-44
56-56: LGTM - Capitalization consistency fixes.These corrections align the comments with the official board name format defined in BOARD_NAME.
Also applies to: 66-66
Description
This change fixes a typo on the board config for Youyeetoo-R1.
No functional or behavioral changes introduced.
Checklist