Skip to content

board: youyeetoo-r1: correct minor typo on the config#8817

Merged
SuperKali merged 1 commit intoarmbian:mainfrom
OpenSource-YYT:yyt-typo
Oct 24, 2025
Merged

board: youyeetoo-r1: correct minor typo on the config#8817
SuperKali merged 1 commit intoarmbian:mainfrom
OpenSource-YYT:yyt-typo

Conversation

@SuperKali
Copy link
Member

Description

This change fixes a typo on the board config for Youyeetoo-R1.
No functional or behavioral changes introduced.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@github-actions github-actions bot added size/small PR with less then 50 lines 11 Milestone: Fourth quarter release Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Oct 24, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

Walkthrough

This pull request modifies the Youyeetoo R1 v3 board configuration file, implementing several refinements: correcting capitalization in comments and descriptive text, reordering boot device precedence to prioritize mmc0 over nvme and mmc1, and refactoring the Wi-Fi driver (rtw89_8852be) configuration logic. The changes introduce an early-exit pattern for branch conditionals and extract driver tweaks into a dedicated post_family_tweaks__youyeetoo_r1 function to manage ASPM/power-save settings specifically for mainline builds.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

The changes are focused on a single board configuration file with mixed modifications: minor formatting adjustments, capitalization corrections, boot order reordering, and logic refactoring with an early-exit pattern. While there is some structural reorganization, the changes follow a consistent pattern and the logic modifications are straightforward. The diff is contained and relatively homogeneous in nature.

Possibly related PRs

Suggested labels

Ready to merge

Suggested reviewers

  • igorpecovnik
  • chainsx
  • catalinii

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The pull request title claims to "correct minor typo on the config," which suggests purely cosmetic or spelling fixes. However, the raw summary reveals substantial changes beyond typos, including boot target order modification (changing mmc0 precedence before nvme and mmc1), reworking of conditional logic for the rtw89_8852be Wi-Fi driver, and the introduction of a new function post_family_tweaks__youyeetoo_r1 for driver configuration. These represent functional and behavioral changes that contradict both the title's implication and the PR description's assertion of "no functional or behavioral changes." The title is therefore misleading about the true scope of the changeset.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed The pull request description is related to the changeset as it references board configuration changes for Youyeetoo-R1, which aligns with the file being modified. While the description is incomplete (it omits the significant boot order and driver configuration changes present in the summary), it is not completely off-topic or unrelated to the changeset. However, the claim of "no functional or behavioral changes" is contradicted by the summary's documentation of boot target reordering and driver logic refactoring.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Oct 24, 2025
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Oct 24, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 42c52e3 and b4e58bf.

📒 Files selected for processing (1)
  • config/boards/youyeetoo-r1-v3.csc (3 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-06-04T23:45:38.860Z
Learnt from: djurny
PR: armbian/build#8272
File: config/bootscripts/boot-mvebu.cmd:182-186
Timestamp: 2025-06-04T23:45:38.860Z
Learning: In config/bootscripts/boot-mvebu.cmd, the `fdtfile` variable is mandatory for booting and is pre-set by U-Boot, but can be overridden via armbianEnv.txt. If `fdtfile` is empty, the subsequent device tree file search logic will eventually fail and trigger the critical error "Cannot find DT!" with proper error handling.

Applied to files:

  • config/boards/youyeetoo-r1-v3.csc
📚 Learning: 2025-09-12T21:44:09.061Z
Learnt from: Grippy98
PR: armbian/build#8624
File: config/boards/sk-am62p.conf:8-8
Timestamp: 2025-09-12T21:44:09.061Z
Learning: For TI K3 family boards in Armbian, BOOT_FDT_FILE uses .dts extension (not .dtb) as the standard convention. The build system handles this correctly by automatically compiling .dts to .dtb during kernel build and using the BOOT_FDT_FILE value directly in bootloader configurations.

Applied to files:

  • config/boards/youyeetoo-r1-v3.csc
🔇 Additional comments (2)
config/boards/youyeetoo-r1-v3.csc (2)

38-38: LGTM - Comment and formatting cleanup.

These comment and formatting adjustments have no functional impact.

Also applies to: 44-44


56-56: LGTM - Capitalization consistency fixes.

These corrections align the comments with the official board name format defined in BOARD_NAME.

Also applies to: 66-66

@SuperKali SuperKali merged commit a7a444f into armbian:main Oct 24, 2025
1 check passed
@SuperKali SuperKali deleted the yyt-typo branch October 24, 2025 07:26
@coderabbitai coderabbitai bot mentioned this pull request Nov 13, 2025
6 tasks
yury-deltsov pushed a commit to yury-deltsov/build that referenced this pull request Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

3 participants