Static description support #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for this! The ability to define your own delimiter, preserve existing configs by adding the delimiter to the end of any static descriptions, or have statics wiped out by having no delimiter covers all use-cases. Rarely is LLDP data the only thing you'd want in the description for all ports on a device so making it selectable is nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original script worked great, but I wanted to be able to set static descriptions on a port and still leverage the tool.
What I've done was to add a configurable text deliminator that separates my static text vs. what gets replaced. ("==>" as a global variable in this pull request) Any data before this deliminator would be preserved, anything after gets wiped and rewritten.
One of the usages I had was noting of circuit IDs on WAN connected ports. This allows me to keep the static description there, but still get the benefits of the script.