Fix: replace failing on "/" character.#1
Open
eli-schwartz wants to merge 1 commit intoarchlinuxfr:masterfrom
Open
Fix: replace failing on "/" character.#1eli-schwartz wants to merge 1 commit intoarchlinuxfr:masterfrom
eli-schwartz wants to merge 1 commit intoarchlinuxfr:masterfrom
Conversation
Member
|
Hi, Haha, ASCII control code are now shown on github web interface, that why I did not understand your diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because this is being used in the sed command as the delimiter. Instead, use an ASCII control code in the assumption that no one else will ever be using that. Alternatively, something like "@" could be used, but that one at least seems to be a fairly common alternative, and won't be proof against further clashes...
So far it's been working for me. :)