Open
Conversation
Add a Dockerfile for using dynalite w/o nodejs.
MrCheater
approved these changes
Jul 30, 2020
Member
|
I'd be amenable to this, may need a few tweaks though. It's not clear from that Dockerfile how ports are configurable there (although to be honest, I'm no Docker expert). Would def want to see some tests too, and probably something around publishing to Docker Hub (which should be easy enough with GitHub Actions). wdyt? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
Dockerfilefor using dynalite w/o nodejs.Unlike #64, this builds from source allowing integration with docker hub by using automated builds.
This would result in having docker hub building and hosting a docker images for each tag and the current latest master/HEAD on each push.
Running dynalite in docker would look like this:
Like the real dynalite executable parameters are available: