Regex tweak to allow use in WordPress themes#25
Open
jpadvo wants to merge 2 commits intoarchan937:masterfrom
Open
Regex tweak to allow use in WordPress themes#25jpadvo wants to merge 2 commits intoarchan937:masterfrom
jpadvo wants to merge 2 commits intoarchan937:masterfrom
Conversation
added 2 commits
December 1, 2010 15:07
Uses a positive lookahead so that topup works when placed in a WordPress theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scriptHost regular expression wouldn't work for long urls like this: http://localhost/project_name/wp-content/themes/theme_name/topup/javascripts/top_up.js
So I tweaked it using a positive lookahead. I posted this as an issue a while back, then learned about the ability to use a pull request. So, if you like it here it is!