Conversation
Switch to new theme and refactored theme code (easy switch, new theme commented)
shaloo
added
documentation
✅ Deploy Preview for arcana-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Resolves or continues AR-9631.
Blocking dependencies
New theme is on hold for now so leaving these changes in PR. I have ensured there are only two switches needed for theme change by refactoring previous code. All changes in main. Just these switches need to be pulled for conversion.
Note: Diagrams (static images) use old theme - design team needs to rework on those.
Mermaid (dynamic diagrams) are already taken care of via the refactoring and switch mechanism.
Changes
New theme via the design team.
Checklist
developer/AR-XXX-issue-name.