Fix for readPolicy filenames that need to be encoded. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if there are spaces in the filename or else you will get a duplicate headers error) and took out the encodeURIComponent of the filename variable.
Author
|
Any chance of this getting merged? My application depends on this change and it's a little difficult to deploy without me putting my fork into NPM. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified read policy to wrap in filename in quotes(chrome needs this if there are spaces in the filename or else you will get a duplicate headers error) and took out the encodeURIComponent of the filename variable(doesn't need to be encoded for the policy).