Open
Conversation
Owner
|
Hello, |
Author
|
Hello, I added a minimal example that uses a custom implementation of the PPOPolicy. |
Owner
|
Sorry, I meant adding it to the description of this PR, not as a test. This should have been done in an issue before creating the PR, in order to understand and discuss the problem (see contributing guide). |
Author
|
I’ve now created the issue and linked it to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PPO currently assumes the optimizer is an optax.chain with two elements.
When using a single-transform optimizer (e.g. optax.adam), learning crashes with an IndexError at sbx/ppo/ppo.py:262.
Fixes #77
Motivation and Context
This fix allows PPO to be used with a wider range of Optax optimizers.
Currently, the assumption about optax.chain length unnecessarily restricts optimizer choices.
Types of changes
Checklist:
make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)make doc(required)