disable uploading source maps for deploying single function#70
Open
fancywriter wants to merge 1 commit intoarabold:masterfrom
Open
disable uploading source maps for deploying single function#70fancywriter wants to merge 1 commit intoarabold:masterfrom
fancywriter wants to merge 1 commit intoarabold:masterfrom
Conversation
Author
|
@arabold hey, did you have a chance to review this? |
Because serverless/serverless#11179 is taking longer to address it's safer to disable this functionality to avoid UX degradation. It's very annoying to see `sls deploy function` failure, much better to have function code actually deployed, but with warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because serverless/serverless#11179 is taking longer to address it's safer to disable this functionality to avoid UX degradation. It's very annoying to see
sls deploy functionfailure, much better to have function code actually deployed, but with warning.