Updated Plugin compliance for Java 8. Changes: Swapped Platform.subMo…

[bensusman]

Updated Plugin compliance for Java 8.

Changes:

• Swapped Platform.subMonitorFor with SubMonitor (deprecation)
• Updated Eclipse settings and classpaths
• Swapped org.eclipse.osgi.service.datalocation with org.eclipse.osgi.service.datalocation (deprecation).

[build]

Can one of the admins verify this patch?

[bensusman]

I'd like to make a Jenkins build, but still trying to understand the process.

Does initiating this PR start a feature branch build which I can test and ensure everything is working appropriately?

[sgtcoolguy]

Opening a PR can kick off a Jenkins build, but we have to "OK" it to run first. It'll run our series of unit tests and let us know if anything broke. I don't think it'll give you a build to try out manually...

[sgtcoolguy]

ok to test

[bensusman]

@sgtcoolguy Thank you for the explanation!

Is there some reason why "Some checks haven’t completed yet"? I could not find how to actually see the pending checks.

[sgtcoolguy]

Looks like our build agent crashed overnight before it got to this. We need to get it up for our own builds internally, so we're working on it...

[sgtcoolguy]

This fails to compile:

23:28:16      [java] @dot:
23:28:16      [java]     [mkdir] Created dir: /data/workspace/studio3-prs/plugins/com.aptana.editor.common/@dot
23:28:16      [java]     [javac] Compiling 214 source files to /data/workspace/studio3-prs/plugins/com.aptana.editor.common/@dot
23:28:24      [java]     [javac] ----------
23:28:24      [java]     [javac] 1. ERROR in /data/workspace/studio3-prs/plugins/com.aptana.editor.common/src/com/aptana/editor/common/AbstractThemeableEditor.java (at line 353)
23:28:24      [java]     [javac]    if (isWordWrapEnabled())
23:28:24      [java]     [javac]        ^^^^^^^^^^^^^^^^^
23:28:24      [java]     [javac] The method isWordWrapEnabled() is undefined for the type AbstractThemeableEditor
23:28:24      [java]     [javac] ----------

[sgtcoolguy]

I think ultimately we should defer to the new builtin support for word wrap, and we should effectively remove our own isWordWrapEnabled() stuff - so that method in AbtsractThemeableEditor, but also the preference constant and UI for setting it in our own pref pages.

[level420]

With current oxygen the plugin fails especially with the following stack trace:

java.lang.IllegalAccessError: com.aptana.editor.js.JSSourceEditor.isWordWrapEnabled()Z
	at org.eclipse.ui.texteditor.WordWrapToggleAction.isWordWrapEnabled(WordWrapToggleAction.java:66)
	at org.eclipse.ui.texteditor.WordWrapToggleAction.update(WordWrapToggleAction.java:57)

It seems that this PR adresses this, so it would be nice to have at least the part in
a55d879
somewhere available.

BTW: currently installing the aptana studion plugin from the eclipse does not work anymore, as the install link isn't available anymore:

http://studio-jenkins.appcelerator.org/job/studio3-feature-development/lastSuccessfulBuild/artifact/dist/

[level420]

Just wanted to ask if someone is currently working on this PR.
Any answer or hint would be great!
Thank you!