feat(fuzzy-finder): add table completion for DUMP TABLES and SHOW CREATE TABLE#529
feat(fuzzy-finder): add table completion for DUMP TABLES and SHOW CREATE TABLE#529
Conversation
…ATE TABLE Add fuzzyCompleteTable completion to two statements that accept table name arguments but previously lacked fuzzy completion: - DUMP TABLES: supports comma-separated multi-table completion - SHOW CREATE TABLE: reuses existing SHOW CREATE completion list Fixes #518 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @apstndb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the command-line interface by integrating fuzzy table completion for the DUMP TABLES and SHOW CREATE TABLE statements. This improvement allows users to more efficiently specify table names, including multiple tables for DUMP TABLES, by leveraging intelligent suggestions. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Code Metrics Report📊 View detailed coverage report (available for 7 days)
Details | | main (2db3383) | #529 (d930775) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 67.6% | 67.6% | 0.0% |
| Files | 55 | 55 | 0 |
| Lines | 6074 | 6074 | 0 |
| Covered | 4108 | 4108 | 0 |
+ | Code to Test Ratio | 1:1.2 | 1:1.2 | +0.0 |
| Code | 13939 | 13947 | +8 |
+ | Test | 17340 | 17396 | +56 |
+ | Test Execution Time | 1m11s | 1m6s | -5s |Code coverage of files in pull request scope (77.2% → 77.2%)
Reported by octocov |
There was a problem hiding this comment.
Code Review
This pull request introduces fuzzy-finder completion for DUMP TABLES and SHOW CREATE TABLE statements. For DUMP TABLES, a completion definition is added with a regular expression that supports comma-separated table names. For SHOW CREATE TABLE, a completion definition is added to the existing SHOW CREATE statement block, consistent with other object types. The pull request also includes new test cases in fuzzy_finder_test.go that validate the completion logic for both statements under various input conditions. No issues were found during the review.
Summary
Add
fuzzyCompleteTablecompletion to two statements that accept table name arguments but previously lacked fuzzy completion.Key Changes
Completionentry to DUMP TABLES with regex supporting comma-separated multi-table input; addfuzzyCompleteTableto SHOW CREATE's existing completion list for TABLE typeTest Plan
make checkpassesFixes #518