feat(fuzzy-finder): add table completion for MUTATE statement#515
feat(fuzzy-finder): add table completion for MUTATE statement#515
Conversation
Add fuzzyCompleteTable to MUTATE statement definition so that MUTATE <Ctrl+T> triggers fuzzy table selection, following the same pattern as TRUNCATE TABLE and SHOW COLUMNS FROM. Fixes #512 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @apstndb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the command-line interface by introducing fuzzy table completion for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Code Metrics Report📊 View detailed coverage report (available for 7 days)
Details | | main (3b1195d) | #515 (4d7c1b2) | +/- |
|---------------------|----------------|----------------|-------|
| Coverage | 68.2% | 68.2% | 0.0% |
| Files | 55 | 55 | 0 |
| Lines | 5912 | 5912 | 0 |
| Covered | 4036 | 4036 | 0 |
+ | Code to Test Ratio | 1:1.2 | 1:1.2 | +0.0 |
| Code | 13570 | 13574 | +4 |
+ | Test | 16914 | 16928 | +14 |
+ | Test Execution Time | 2m9s | 1m7s | -1m2s |Code coverage of files in pull request scope (79.9% → 79.9%)
Reported by octocov |
There was a problem hiding this comment.
Code Review
The pull request successfully adds fuzzy table completion for the MUTATE statement, which is a valuable enhancement for user productivity. The implementation follows the existing patterns in the codebase and includes appropriate test cases. The previously identified high-severity issue regarding the MUTATE statement's main regex pattern has been re-evaluated against repository rules and found to be acceptable, as the pattern's purpose is to trigger completion, not to fully parse complex identifiers like quoted or spaced names (Rule 5).
Summary
Add fuzzy table completion to the MUTATE statement, so
MUTATE <Ctrl+T>triggers fuzzy table selection.Key Changes
Completionfield withfuzzyCompleteTableto the MUTATE statement definitionTest Plan
make checkpassesMUTATE <Ctrl+T>opens fuzzy finder with table candidatesFixes #512