Decode JSON responses in UTF-8, not Latin-1#86
Closed
jlahd wants to merge 1 commit intoappsup-dart:masterfrom
Closed
Decode JSON responses in UTF-8, not Latin-1#86jlahd wants to merge 1 commit intoappsup-dart:masterfrom
jlahd wants to merge 1 commit intoappsup-dart:masterfrom
Conversation
|
Looks like a duplicate from: #79 |
Author
|
True, it is. Sorry, missed the original PR and reinvented the wheel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per RFC 4627, JSON is UTF-8 by default (with UTF-16 or UTF-32 as other two possible encodings). However, the http library uses Latin-1 decoding, unless there is an explicit character set definition in the response headers.
Most notably, this breaks
Credential.getUserInfo()when the user's name has non-ASCII characters in it.