Open
Conversation
Author
|
Device Authorization Flow was missing and as I need it for a project I decided to send you this PR with necessary implementation for this flow. |
commit 2fc190c Author: Luca Fabbri <luca@zepfiro.com> Date: Tue Feb 14 19:11:44 2023 +0100 Update README.md commit fdfca43 Author: Luca Fabbri <luca@zepfiro.com> Date: Tue Feb 14 19:04:07 2023 +0100 Update openid.dart commit 1aacec3 Merge: 2f513f3 985b678 Author: Luca Fabbri <luca@zepfiro.com> Date: Tue Feb 14 10:10:41 2023 +0100 Merge branch 'feature/device-code-flow' of https://github.com/lucafabbri/openid_client into feature/device-code-flow commit 985b678 Author: lfabbri <luca@zepfiro.com> Date: Mon Feb 13 20:36:16 2023 +0100 Device Authoriation Flow commit 2f513f3 Author: lfabbri <luca@zepfiro.com> Date: Mon Feb 13 20:36:16 2023 +0100 wip
Author
|
Any change you will evaluate this improvement? |
rbellens
requested changes
Oct 13, 2023
Contributor
rbellens
left a comment
rbellens
left a comment
There was a problem hiding this comment.
Can you please remove all changes related to formatting. It is hard to evaluate the things that actually changed when so many code lines have changed.
Author
|
hi @rbellens i made the changes requested |
Author
|
@rbellens any news on merging this feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.