Allow Appium to Scroll To a particular element on screen #109
Conversation
|
Thanks for your contribution @nkjith Just FYI: we are currently working on a next-gen mac driver based on XCTest - https://github.com/appium/appium-mac2-driver |
|
|
||
| -(BOOL) scrollPage:(id)element | ||
| { | ||
| float increment_by = 0.25; |
There was a problem hiding this comment.
could you please use camelCase naming to match with the current project coding style?
| -(BOOL) scrollPage:(id)element | ||
| { | ||
| float increment_by = 0.25; | ||
| bool scroll_found = false; |
There was a problem hiding this comment.
Please use YES/NO constants with BOOL type
| float increment_by = 0.25; | ||
| bool scroll_found = false; | ||
| PFUIElement* scroll; | ||
| float axValue = 0,adder = 0; |
There was a problem hiding this comment.
please define variables closer to the block where they used, also each variable should be defined in its own row
| PFUIElement* scroll; | ||
| float axValue = 0,adder = 0; | ||
|
|
||
| id parent = [(PFUIElement*)element AXParent]; |
There was a problem hiding this comment.
can the parent's type be more specific?
| { | ||
| for(id child in siblings) | ||
| { | ||
| if([[(PFUIElement*)child AXRole] isEqualToString:@"AXScrollBar"]) |
There was a problem hiding this comment.
is there any reason to define the child element type as id in the loop and cast it to PFUIElement* here?
| NSPoint middlePoint = [[element AXPosition] pointValue]; | ||
| if(middlePoint.y < 0) | ||
| { | ||
|
|
There was a problem hiding this comment.
should this block be empty?
| id parent = [(PFUIElement*)element AXParent]; | ||
| NSArray* siblings = [parent AXChildren]; | ||
|
|
||
| while(scroll == nil && parent != nil) |
There was a problem hiding this comment.
please add space after while, if and other similar keywords to match with the common project style
| siblings = [parent AXChildren]; | ||
| } | ||
|
|
||
| NSPoint middlePoint = [[element AXPosition] pointValue]; |
There was a problem hiding this comment.
what middlePoint is used for?
| while(adder<=1) | ||
| { | ||
| axValue = [scroll.AXValue floatValue]; | ||
| adder = axValue + increment_by; |
There was a problem hiding this comment.
would it be possible to have more descriptive name for the adder variable?
|
|
||
| } | ||
|
|
||
| if(scroll_found) |
There was a problem hiding this comment.
we could immediately return NO here if the var is false
|
|
||
|
|
||
| // POST /session/:sessionId/element/:id/scrollTo | ||
| // Scroll to the particular element passed to Appium. Scrolls till the bottom of the screen till the element becomes visible |
There was a problem hiding this comment.
is it always the case we need to scroll to the bottom? what if the destination element is located in the other direction, for example upper or at the right side?
2 participants
Adding Scroll To functionality which will help OSX Applications to scroll to a particular element.
The code increments the scroll bar and checks if the passed on element is visible.