Skip to content

Conversation

@davidmezzetti
Copy link
Contributor

I noticed a couple other things while testing as follows:

  • Fix bug with get_node_by_id. This makes the behavior consistent with get_edge_by_id.
  • This PR also adds remove_node to writable methods for InMemoryCachedBackend. This fixes a caching issue when a node is removed.

I want to be respectful of your time, so I can handle these changes locally until you have time to integrate and push a release. Thanks again for all the help!

…d. Add remove_node to writable methods for InMemoryCachedBackend.
@j6k4m8
Copy link
Member

j6k4m8 commented Dec 8, 2024

grr, broken codspeed CI... one sec! trying to resolve in #60

Copy link
Member

@j6k4m8 j6k4m8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great — will roll a minor release (v0.6.0) to PyPI once this passes CI!

@j6k4m8 j6k4m8 merged commit a9d6a52 into aplbrain:master Dec 8, 2024
5 of 6 checks passed
@j6k4m8
Copy link
Member

j6k4m8 commented Dec 8, 2024

I want to be respectful of your time, so I can handle these changes locally until you have time to integrate and push a release. Thanks again for all the help!

VERY MUCH appreciate this! But whenever possible I am excited to get your PRs merged in upstream as quickly as possible — will try my best to keep this moving rapidly to stay off your critical path! It's always awesome to see a PR coming from you and know that the ecosystem is about to get better!!

This change is now live on PyPI in v0.6.0 and later.

@davidmezzetti
Copy link
Contributor Author

Much appreciated! Everything is working on my end with these changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants