Parallel rspec by apiology · Pull Request #27 · apiology/solargraph

apiology · 2026-01-31T21:40:37Z

No description provided.

On my machine, I got a 33% speed-up with these tweaks: before: Finished in 1 minute 15.88 seconds after: Finished in 49 seconds

@todos

* Fix merge * Adjust annotations * Fix typecheck errors * Fix merge * Fix merge * Fix some @sg-ignores * Fix merge * Merge branch 'intersection_types' into flow_sensitive_typing_2_0 * Fix RuboCop issue * Fix type issues * Fix type issues * Fix rspec.yml * Fix rspec.yml * Add @sg-ignores * Remove @sg-ignores * Merge branch 'or_support_in_flow_sensitive_typing' into union_type_enforcement * Fix spec * Fix annotations * Fix RuboCop issues * Bump RBS versions in rspec test * Fix version * Fix version matrix * Fix version matrix * Fix version matrix * Fix version matrix * Fix version matrix * Exclude another * Exclude another * Add version, fix doc * init -> config * Fix rbs-version for Ruby 4.0 in CI workflow * Clean up ruby-version entries in rspec.yml Removed deprecated ruby-version entries for RBS. * Fix RBS version for Ruby 4.0 in workflow * Fix merge * Improve signature combination Use our generated RBS signature from parameters as a key to combine method signatures from RBS/YARD pins. This is closer to what RBS does than the current technique of using the arity alone, and fixes a key degenerate case in Integer#+ revealed by updated definitions used by recently released RBS gems * Update annotations * Drop annotation * Fix RuboCop issue * Fix merge * Don't use solargraph-rspec branch * Fix merge * Debug * Add another use of stdlib dependencies in RBS * Mock additional call * Fix annotations * Update types in rspec undercover * Debug * Debug * Drop incorrect rbs collection use in spec * Update rubocop todo * Revert change * Fix RuboCop issue * Fix annotations * Fix annotations * RuboCop fix * Use "type arity" to guide signature combination * Update rubocop todo * Include return type arity in comparison * Add dodgy return type * Fix RuboCop issue * Add Ruby 4.0 jobs * Exclude another combo * Exclude another combo * Update rules to use report? * Fix merge * Fix merge * Drop dead code * Bump version to 0.59.0.dev.1 * Rename rule * Update RuboCop todo file * Update RuboCop todo file * Ratchet rubocop TODO file * Move to skip: * Mark spec as pending * Revert spec change * Drop old workaround * Fix merge * Fix typechecking issues * Revert doc * Fix spelling * Fix merge issue * Exclude the current gemspec from pins brought in from gem * Check pathname instead * Add sg-ignore * Avoid rbs pollution We were using the sig/shims directory for some internally helpful shims; unfortunately that exported them during gem installs, causing castwide#1144 * Test with RBS 4.0.0.dev.5 * Open up in gemspec * Fix missing spot * Typecheck using RBS prereleases * Move point of ignoring cached gems for gem projects * Fix issues resolving cgi escape functions * Be more careful marking things as stdlib * Reclassify rbs gem * Fix merge * Add sg-ignore * Fix merge * Remove outdated workaround * Fix @sg-ignore name * Restore workaround * Restore workaround * Merge branch 'flow_sensitive_typing_2_0' into 2025-01-06 * Fix method signature * Fix annotations * Add regression test and fix for issue found during future merge * Add regression test and fix for issue found during future merge * Fix merge * Fix merge * Fix merge * Fix merge * Use correct field for self type resolution Add a regression test and fix for self type resolution issue found on a future branch * Fix 'solargraph pin --references ClassName' private method call * Add error handling * Fix another location with another test case * Drop now-unneeded @sg-ignore * Don't log caching for each dependent library This causes duplicate logging on standard libraries, many of which are esoteric (e.g., "cgi-escaping"). The current method as of the 2025-01-06 branch would result in each stdlib library being cached individually. * Drop logging entirely * Fix some types based on future branch feedback * Provide Gem::Specification to outside interface * Provide Gem::Specification to outside interface * Use #to_spec * Provide Gem::Specification to outside interface * Fix typechecking error * Use consistent bundler versions * Fix type issue * Fix annotations based on future branch feedback * Add some @todos * Fix annotations * Fix annotations * Fix annotation * Add diff::lcs shim * Improve spec expectations * Add @sg-ignore * Fix rspec checks to run on all types of PRs * Fix merge * Fix merge * Fix merge

Fix issue revealed by more aggressive setting of debug logging

This seems to reproduce when not run in order with other specs in file

apiology · 2026-02-06T19:54:54Z

.github/workflows/plugins.yml


 jobs:
-  regression:
+  rails_and_rspec_typechecking:


I'm breaking these steps into parallel items for time savings and also clearing up the names a bit

apiology · 2026-02-06T20:14:12Z

lib/solargraph/complex_type/unique_type.rb

-        elsif name == GENERIC_TAG_NAME
-          all_params.first&.name
+        elsif name == GENERIC_TAG_NAME && !all_params.empty?
+          all_params.first.name


This is a different fix than I merged in after the spec failure, but maintains the type better

apiology · 2026-02-06T20:17:36Z

lib/solargraph/diagnostics/type_check.rb

        # @sg-ignore sensitive typing needs to handle || on nil types
-        checker = Solargraph::TypeChecker.new(source.filename, api_map: api_map, level: level.to_sym)
+        checker = Solargraph::TypeChecker.new(source.filename, api_map: api_map, level: level.to_sym,
+                                                               workspace: workspace)


Avoid doing more than necessary in specs by allowing a custom small workspace to be used.

apiology · 2026-02-06T20:51:23Z

lib/solargraph/source/chain.rb

+            "locals=#{locals.map(&:desc)}, " \
+            "name_pin=#{name_pin}, " \
+            "name_pin.closure=#{name_pin&.closure.inspect}, " \
+            "name_pin.binder=#{name_pin&.binder}) => #{out.rooted_tags.inspect}"


Fix some issues found with more consistent use of the debug level in specs

apiology · 2026-02-06T20:52:33Z

lib/solargraph/workspace/config.rb

+                       ''
+                     else
+                       File.absolute_path(directory)
+                     end


Some of the directory = '' handling wasn't being done properly, leading to the specs pulling in the solargraph directory's config when it should be the default config

apiology · 2026-02-06T23:00:52Z

spec/yardoc_spec.rb

      described_class.build_docs(gem_yardoc_path, [], gemspec) # second time
-      expect(File.exist?(File.join(gem_yardoc_path, 'complete'))).to be true
+
+      expect(Open3).to have_received(:capture2e).once


Speed up this slow spec by mocking expensive things not done by this class itself.

apiology · 2026-02-06T23:02:27Z

spec/workspace/gemspecs_resolve_require_spec.rb

-    rescue Gem::SystemExitException => e
-      raise unless e.exit_code == 0
-    end
-  end


Move these to the only scope where they are actualy used

apiology · 2026-02-06T23:02:44Z

spec/type_checker/levels/strict_spec.rb

        end
      ))
-      expect(checker.problems.map(&:message)).to eq(['Unresolved call to upcase'])
+      expect(checker.problems.map(&:message)).to eq(['Unresolved call to upcase on nil'])


This works now!

apiology · 2026-02-06T23:05:52Z

spec/pin/base_spec.rb

-    Solargraph::Shell.new.uncache('yard')
-    api_map = Solargraph::ApiMap.load_with_cache('.', $stderr)
+    # if this fails you might not have an rbs collection installed
+    api_map = Solargraph::ApiMap.load ''


Avoid caching every gem!

apiology added 30 commits January 15, 2026 09:49

Spec performance fixes

29fbd34

On my machine, I got a 33% speed-up with these tweaks: before: Finished in 1 minute 15.88 seconds after: Finished in 49 seconds

Add rbs collection in undercover run

70ea4bb

Add rbs collection in undercover run

8c049fb

Fix copy-and-paste-o

e428f80

Perform specific caching

ffc25d6

Merge remote-tracking branch 'castwide/v0.59' into speed_up_specs

79d9efb

Ensure api_map catalogs new pins

861a899

Avoid cache_doc_map_gems if possible

9216d73

Avoid load_with_cache if possible

7741fca

Avoid load_with_cache if possible

80e0c94

Use library with fewer dependencies to cache

c0596ad

Simulate yardoc run

55612e7

Add bundle cache

c5d5843

Add empty lines

9d725f3

Cache bundles

a6df0bf

Split up regression cases

f4ad280

Run specs in parallel

98851f4

Add gem

5749c42

Finish Rakefile changes

2888594

Fix issue revealed by more aggressive setting of DEBUG log level

afb3fe0

Use valid values for parameters in tests

310408e

Fix issue revealed by more aggressive setting of debug logging

Add missing step in spec

750b371

This seems to reproduce when not run in order with other specs in file

Add .envrc to set number of parallel jobs

f8da41c

Add debug logging

d4a21e6

Merge branch 'better_logging_testing' into parallel_rspec

2e94d97

Rely on bundler installed by ruby/setup-ruby

70f0c5f

Merge branch 'speed_up_specs' into parallel_rspec

96ef0c5

Swap to name that prspec triggers on

7a05bb2

Set PARALLEL throughout based on number of physical cores

c26e6d6

apiology commented Feb 6, 2026

View reviewed changes

Consistency fixes

25457a8

apiology commented Feb 6, 2026

View reviewed changes

apiology added 2 commits February 6, 2026 13:14

Drop @param

3e85551

Docs

d10e029

apiology commented Feb 6, 2026

View reviewed changes

apiology added 2 commits February 6, 2026 13:18

Drop debugging

a4bd2bd

Drop debugging

16fb502

apiology commented Feb 6, 2026

View reviewed changes

apiology added 5 commits February 6, 2026 13:54

Revert debugging

d707e04

Drop unneeded Config.new

b8b18c4

Revert updates

aa8979c

Fix annotation

fefdeba

Revert

792e857

apiology commented Feb 6, 2026

View reviewed changes

apiology added 11 commits February 6, 2026 16:08

Fix log message

23ccc34

Cache workspace gems in parallel

6e06cd2

Cache workspace gems in parallel

a1aeac2

Cache docmap gems in parallel

81b3ae0

Add --workspace flag, default to docmap caching

91b8852

Fix API break

013deaf

Fix nil issue

98953f7

Fix spec

e0b28e0

Cache more up front in rspec_specs

c6d7ea9

Drop unneeded nil case

1f599e9

Avoid chdir issues

17d3a2b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parallel rspec#27

Parallel rspec#27
apiology wants to merge 193 commits into2026-01-31from
parallel_rspec

apiology commented Jan 31, 2026

Uh oh!

apiology Feb 6, 2026

Uh oh!

apiology Feb 6, 2026

Uh oh!

apiology Feb 6, 2026

Uh oh!

apiology Feb 6, 2026

Uh oh!

apiology Feb 6, 2026

Uh oh!

apiology Feb 6, 2026 •

edited

Loading

Uh oh!

apiology Feb 6, 2026

Uh oh!

apiology Feb 6, 2026

Uh oh!

apiology Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

apiology commented Jan 31, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

apiology Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

apiology Feb 6, 2026 •

edited

Loading