Improved repr

[orgh0]

@sushain97 Could you review this ?

[coveralls]

Pull Request Test Coverage Report for Build 176

• 42 of 44 (95.45%) changed or added relevant lines in 5 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.7%) to 81.135%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
apertium/init.py	6	8	75.0%

Files with Coverage Reduction	New Missed Lines	%
apertium/generation/init.py	1	96.67%

Totals
Change from base Build 159:	0.7%
Covered Lines:	615
Relevant Lines:	758

---

💛 - Coveralls

[sushain97]

Looks like you're almost there. Do you mind adding a few tests?

[sushain97]

Merge conflict artifacts?

[orgh0]

@sushain97 No worries, I'll add tests :)

[sushain97]

These need single quotes. Generator(lang=eng) itself would error. Similar concern with the others.

[orgh0]

@sushain97 Just to check if I understand this properly,
The issue is that 'Generator(lang=eng)' is being returned by the function as a string?
But wasn't that the point of repr, it returns a printable representation of the object

[sushain97]

No, the problem is eng should be enclosed in single quotes.

…

On Tue, Jul 10, 2018, 6:49 AM Arghya Bhatttacharya ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In tests/__init__.py <#27 (comment)> : > @@ -68,6 +75,14 @@ def test_uninstalled_mode(self): with self.assertRaises(apertium.ModeNotInstalled): apertium.generate('spa', 'cat<n><pl>') + def test_repr(self): + generator = apertium.Generator('eng') + self.assertEqual(repr(generator), 'Generator(lang=eng)') @sushain97 <https://github.com/sushain97> Just to check if I understand this properly, The issue is that 'Generator(lang=eng)' is being returned by the function as a string? But wasn't that the point of repr, it returns a printable representation of the object — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEBEfvUePK18Kbz6uwG4c-qNzl9xpr0-ks5uFLD1gaJpZM4VGqra> .

[orgh0]

@sushain97 But why? I don't quite understand what the problem with the current repr and str function is

Sorry for the inconvenience 😅

[orgh0]

@sushain97 I've changed the code according to my understanding, please review and let me know if I have it right.

[sushain97]

But why? I don't quite understand what the problem with the current repr and str function is

The issue is that Generator(lang=eng) will syntax error if I put it into a REPL.

[sushain97]

The str versions aren't meant to be runnable so they don't need (or should have) the quotes.