Skip to content

feature(jackson) switch to jackson 3#1097

Open
antechrestos wants to merge 1 commit intoapereo:masterfrom
antechrestos:feature/upgrade-to-jackson-3
Open

feature(jackson) switch to jackson 3#1097
antechrestos wants to merge 1 commit intoapereo:masterfrom
antechrestos:feature/upgrade-to-jackson-3

Conversation

@antechrestos
Copy link

This modification aims to provide a migration to jackson 3.

This way, each spring boot 4 project won't get the dependency of jackson-databind by transitivity.

I hesitated to set the version to 4.1.0but though it was out of my responsibility 😄

Whatever the return, I will gladly read and take any remarks into considerations.

Cheers 🍻

@antechrestos
Copy link
Author

@mmoayyed @philippberger @larsgrefer @mattj65817
Hi

I allow myself to notify you as you four are the only humans having pushed a commit in the last two years 😊

As you must know, springboot 4 was released with a migration towards Jackson 3.
When using spring boot 4 with this library, it sets a dependency to Jackson 2,leading to possible confusion in imports.

That is why I push this small evolution to solve this issue.

Please let me know if you agree with this change or if some evolutions need to be done.

@mmoayyed
Copy link
Member

Thank you for submitting this. I agree that strategically, this is the right move. This would be something that we might consider for the next major version of the client, and as of this moment, there are no plans or intentions to release anything until we the maintainers have clear and unavoidable justification for the time required to work on the next release.

@antechrestos
Copy link
Author

@mmoayyed thank you for your reply, I understand your point of view.

However I had an idea: what would you think of a bi mode implementation ie

  • setting jackson 2 as provided
  • setting jackson 3 as provided
  • adding and interface whose aim is to hide jackson stuffs
  • according to ConditionalOnClass having the right implementation
  • use the interface where jackson was directly used

This way this will not break the fact that your library is compatible with springboot 3 and springboot 4 (jackson 3 or not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants