UNOMI-911: fix sslcontext initialization #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayblanc
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/UNOMI-911
This pull request refactors the way SSL context is handled when creating the Elasticsearch client. The main changes focus on ensuring that the SSL context is only set when the "trust all certificates" option is enabled.
Elasticsearch client initialization improvements:
ElasticSearchPersistenceServiceImpl.javato initializeElasticsearchClientFactory.ClientBuilderonce and only set the SSL context ifsslTrustAllCertificatesis true, avoiding unnecessary SSL context usage.sslContext) on the client builder inside the conditional block forsslTrustAllCertificates, ensuring it is only set when appropriate.