Skip to content
This repository was archived by the owner on Jun 7, 2021. It is now read-only.

Conversation

@mashengchen
Copy link
Contributor

@mashengchen mashengchen commented Jun 12, 2018

it's hard to update statistic message each time row datas change. so current version does not support CARDINALITY.

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2742/

@Traf-Jenkins
Copy link

@selvaganesang
Copy link
Contributor

It looks like the change made via #594 to make the squirel to work is being undone. Is that what you wanted?

@mashengchen
Copy link
Contributor Author

no, actually i remove the sb_histograms , because the MD schema does not have that table, also if there does not do update stastisitc, the CARDINALITY will not correct.
i discuss with @venkat1m , he can explain more.

@DaveBirdsall
Copy link
Contributor

@mashengchen, @selvaganesang, @venkat1m: Where does this change stand? Is it ready for merging? Does it require more work?

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2879/

@Traf-Jenkins
Copy link

@mashengchen
Copy link
Contributor Author

jenkins,retest

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2944/

@Traf-Jenkins
Copy link

@moscowgentalman
Copy link
Contributor

@mashengchen, @selvaganesang, @venkat1m: Where does this change stand? Is it ready for merging? Does it require more work?

@mashengchen
Copy link
Contributor Author

@traflm this PR is for the bug which can get index in MD schema by the getIndexInfo api, but one can get result by using get indexes in trafci or sqlci

@DaveBirdsall
Copy link
Contributor

@selvaganesang and @venkat1m: Do you have further comments? Or should I merge this?

@DaveBirdsall
Copy link
Contributor

jenkins, retest

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3072/

@Traf-Jenkins
Copy link

@selvaganesang
Copy link
Contributor

selvaganesang commented Dec 21, 2018

It looks like GetStatistics API was displaying some information about the table itself to take into account the primary key earlier. I am assuming that the primary key acts like an implied index that needs to be displayed as part of GetStatistics API.

Yes. It is incorrect to use sb_histograms table, but I fear that the row pertaining to the primary key is being completely removed from the output with this change. Hence can you please attach the output of the catalog API before and after your change to determine if this change can be merged. So my comment about #594 still stands good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants