Skip to content

Conversation

@cynthiagu23
Copy link

add 3 configurations for the environment:

  1. --sleep-in-sec to allow enough sleep time for async log to write out
  2. --keep-tmp to keep the /tmp folder for debug purpose
  3. --standalone-ats-port allow a separate deployment of ats

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably need to follow the same server_ports markup that we have in records.config-- since ATS ports have different attributes associated with them (such as ipv4:443 -- https://docs.trafficserver.apache.org/en/latest/reference/configuration/records.config.en.html#proxy-config-http-server-ports)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are both if checks necessary? And if so, can we put them in one line?

@jacksontj
Copy link
Contributor

@cynthiagu23 Few comments left unfixed, once those are taken care of I think we are good to merge :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is ZPL compatible with Apache?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think all we have to do, is add this notice to the NOTICE file, like we do in ats itself
https://github.com/apache/trafficserver/blob/master/NOTICE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants