-
Notifications
You must be signed in to change notification settings - Fork 13
add configuration plugin #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
tsqa/conf_plugin.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably need to follow the same server_ports markup that we have in records.config-- since ATS ports have different attributes associated with them (such as ipv4:443 -- https://docs.trafficserver.apache.org/en/latest/reference/configuration/records.config.en.html#proxy-config-http-server-ports)
…g to comply with ATS settings
tsqa/environment.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are both if checks necessary? And if so, can we put them in one line?
|
@cynthiagu23 Few comments left unfixed, once those are taken care of I think we are good to merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is ZPL compatible with Apache?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think all we have to do, is add this notice to the NOTICE file, like we do in ats itself
https://github.com/apache/trafficserver/blob/master/NOTICE
add 3 configurations for the environment: